932112 - Update WebRTC code to webrtc.org stable branch 3.43

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

3.43 is being used in Chrome 31, to be released soon.

We'll keep the new AEC code on top of it

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add stdc++-compat hack for std::__detail::_List_node_base::_M_reverse, necessary for webrtc update

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add stdc++-compat hack for std::__detail::_List_node_base::_M_reverse, necessary for webrtc update

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03701a9c0f82

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/03701a9c0f82

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Add a non-ARM MemoryBarrier function. r=

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Don't free the global, shared Context ref. r=

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 827769 [details] [diff] [review]
Add a non-ARM MemoryBarrier function. r=

Why not just use __sync_synchronize() all the time?  Less ugly and the compiler will basically do the same thing (or perhaps it'll be hidden in the runtime somewhere) as your casting hack.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

FYI, Try:  https://tbpl.mozilla.org/?tree=Try&rev=236239b6f7be

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Initialize both JNI and OpenSLES so fallback can work.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Attachment: JB reflect for low-latency params r=

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Use the non-main-thread FindClass implementation r=

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 827769 [details] [diff] [review]
Add a non-ARM MemoryBarrier function. r=

Note: this patch is used for opensles drivers, which means android and gonk only.

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Tested with our internal tests, apprtc, gupshup, and some others.  (Can't test with talky.io because of bug 934378)

Let's get it in before bitrot ensues!

Comment 15

[Mike Hommey [:glandium]]

Comment on attachment 827769 [details] [diff] [review]
Add a non-ARM MemoryBarrier function. r=

Review of attachment 827769 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/modules/audio_device/android/single_rw_fifo.cc
@@ +25,5 @@
>    // barrier.
>    typedef void (*KernelMemoryBarrierFunc)();
>    ((KernelMemoryBarrierFunc)0xffff0fa0)();
> +#else
> +  __sync_synchronize();

I agree with Nathan, you can just use __sync_synchronize() everywhere.

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Add a non-ARM MemoryBarrier function. r=

Comment 17

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 827845 [details] [diff] [review]
Add a non-ARM MemoryBarrier function. r=

Per IRC

Comment 18

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 827770 [details] [diff] [review]
Don't free the global, shared Context ref. r=

Review of attachment 827770 [details] [diff] [review]:
-----------------------------------------------------------------

I think I already r+'d this

Comment 19

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 827782 [details] [diff] [review]
JB reflect for low-latency params r=

Review of attachment 827782 [details] [diff] [review]:
-----------------------------------------------------------------

I wrote this patch, so I probably shouldn't review it

Comment 20

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 827782 [details] [diff] [review]
JB reflect for low-latency params r=

Transition to reflection looks like it covers the bases

Comment 21

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 827783 [details] [diff] [review]
Use the non-main-thread FindClass implementation r=

Review of attachment 827783 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/modules/audio_device/android/audio_manager_jni.cc
@@ +85,4 @@
>    // Create a global reference such that the class object is not recycled by
>    // the garbage collector.
> +  g_audio_manager_class_ = jsjni_GetGlobalClassRef(
> +    "org/webrtc/voiceengine/AudioManagerAndroid");

What thread is this being run on? It will dispatch a runnable synchronously to the main thread, which means it will block waiting for the main thread. Is that ok?

Comment 22

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 827783 [details] [diff] [review]
Use the non-main-thread FindClass implementation r=

Review of attachment 827783 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/modules/audio_device/android/audio_manager_jni.cc
@@ +85,4 @@
>    // Create a global reference such that the class object is not recycled by
>    // the garbage collector.
> +  g_audio_manager_class_ = jsjni_GetGlobalClassRef(
> +    "org/webrtc/voiceengine/AudioManagerAndroid");

> What thread is this being run on? It will dispatch a runnable synchronously to the main thread, which means it will block waiting for the main thread. Is that ok?

This will end up running on the MediaThread (the backend MediaManager's thread for interfacing with the media code).  Blocking it on MainThread (once? or once per GetUserMedia call?) probably isn't a huge problem.

Comment 23

[Randell Jesup [:jesup] (needinfo me)]

Ready for checkin
https://tbpl.mozilla.org/?tree=Try&rev=236239b6f7be

Comment 24

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7aca035355ae
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd8f1571937f
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b8a157a6ed5
https://hg.mozilla.org/integration/mozilla-inbound/rev/32d82a576615
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0e8a46aad5f
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc7e3ef4bb80
https://hg.mozilla.org/integration/mozilla-inbound/rev/4481461159f2

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7aca035355ae
https://hg.mozilla.org/mozilla-central/rev/bd8f1571937f
https://hg.mozilla.org/mozilla-central/rev/5b8a157a6ed5
https://hg.mozilla.org/mozilla-central/rev/32d82a576615
https://hg.mozilla.org/mozilla-central/rev/d0e8a46aad5f
https://hg.mozilla.org/mozilla-central/rev/cc7e3ef4bb80
https://hg.mozilla.org/mozilla-central/rev/4481461159f2