Update builders to Android SDK platform 17

RESOLVED FIXED

Status

Release Engineering
Platform Support
--
major
RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: gcp, Assigned: tbsaunde)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(4 attachments)

(Reporter)

Description

4 years ago
The updated webrtc.org code has a new audio backend that's using some new features in Android 4.2/17 to detect the native sampling rate of the device and the minimal audio buffers required:
http://developer.android.com/reference/android/media/AudioManager.html#PROPERTY_OUTPUT_FRAMES_PER_BUFFER
http://developer.android.com/reference/android/media/AudioManager.html#PROPERTY_OUTPUT_SAMPLE_RATE

In order to use this, we will need to update to platform-17, i.e. ANDROID_SDK_VERSION=17 for the builders and mozconfigs.
(Reporter)

Updated

4 years ago
Blocks: 899204
Blocks landing the webrtc.org update, which is almost ready.  Can we deal with this soon?

Ted/blassey: who should take this?
Blocks: 932112
Flags: needinfo?(ted)
Flags: needinfo?(blassey.bugs)
(Reporter)

Comment 2

4 years ago
>Blocks landing the webrtc.org update

We could unblock it by patching out the new code, and add a seperate bug "restore low-latency support" that's blocked on this. If needed.
This would be a release engineering bug. Callek, will you be taking it?
Component: General → Platform Support
Flags: needinfo?(ted)
Flags: needinfo?(bugspam.Callek)
Flags: needinfo?(blassey.bugs)
Product: Firefox for Android → Release Engineering
QA Contact: coop
Version: Trunk → unspecified
Let's hold off on this for now and just use reflection for the required code (It's only 2 constants and one method)
Flags: needinfo?(bugspam.Callek)
(Assignee)

Comment 5

4 years ago
fixing this shouldn't be all that hard, but I'm not sure I have time this week.  What needs to happen is this

1. download the linux x86_64 android sdk.
2. untar it strip out obviously useless garbage and retar it. Saddly I didn't scriptify this for the sdk, but it should more or less be the same as the ndk script in people.mozilla.org/~tsaunders/ndk.sh.txt
3. put that tarball someplace some place on the internet and get someone in releng to add it to tooltool.
4. change the mozconfigs in mobile/android/config/mozconfigs and the tooltool manifests in mobile/android/config/ to have the right check sums and file sizes.
Who can we assign this bug to? We need SDK 17 to land the RTL work for Firefox (bug 702845).
Blocks: 702845
I'm looking into whom in releng can take this work. (after being pinged by blassey due to it blocking a locale from landing)

"[11:23:46]	blassey	deadline is trunk becoming 32
[11:24:03]	blassey	which is April 19"
Assignee: nobody → bugspam.Callek
Flags: needinfo?(bugspam.Callek)
For further info we have:

Android SDK16 in rpm form (+ spec) at
And Android SDK18 for Deb/Ubuntu in the same folder:
http://mxr.mozilla.org/build/source/puppet/modules/packages/manifests/mozilla/

Lastly a rough doc I found with some searching (unsure how relevant) which was created by :coop  https://wiki.mozilla.org/ReleaseEngineering/How_To/Build_An_Android_SDK_rpm


For added context to help whomever works on it:
Android SDK 16 was created in Bug 775720
(Assignee)

Comment 9

4 years ago
(In reply to Justin Wood (:Callek) from comment #8)
> For further info we have:
> 
> Android SDK16 in rpm form (+ spec) at
> And Android SDK18 for Deb/Ubuntu in the same folder:
> http://mxr.mozilla.org/build/source/puppet/modules/packages/manifests/
> mozilla/
> 
> Lastly a rough doc I found with some searching (unsure how relevant) which
> was created by :coop 
> https://wiki.mozilla.org/ReleaseEngineering/How_To/Build_An_Android_SDK_rpm
> 
> 
> For added context to help whomever works on it:
> Android SDK 16 was created in Bug 775720

We've been using an sdk from tooltool since bug 859984, and while l10n builds didn't initially do the same (iirc)  they appear to today according to https://tbpl.mozilla.org/php/getParsedLog.php?id=35210003&tree=Mozilla-Central
(Assignee)

Comment 10

4 years ago
I have a bit of time know, so I'm testing a tarball with sdk 17 as I write this.
Assignee: bugspam.Callek → trev.saunders
(Assignee)

Comment 11

4 years ago
Created attachment 8382450 [details] [diff] [review]
teach android.m4 about build tools v 19.0.2

Grabbing the latest android sdk gets me the build tools in $sdkdir/build-tools/19.0.2/ so lets teach android.m4 about that location too
Attachment #8382450 - Flags: review?(mshal)
(Assignee)

Comment 12

4 years ago
jhopkins can you please upload 
people.mozilla.org/~tsaunders/setup.sh.ndk
and
people.mozilla.org/~tsaunders/android-sdk.tar.xz
to tooltool? thanks!
Flags: needinfo?(jhopkins)
android-sdk.tar.xz 69c9be39a452c202ebe99fa3a7f31cb9a8028a8413afc344ef80d0f0d41e28c25cc9ad634e24e23639792b19f07d6acc22494429789dde725d8e202fe5625e27

setup.sh.ndk 5aaec0a91da377fb1bf86ac2a28a2adea3d3f7736b71c0fb2249ae8ca0ff66731311f89c9e933f0944e8e5771a0c14d6a3055f181721f52a0cd5397f175bcb14
Flags: needinfo?(jhopkins)
Again, with filesize:

filename: android-sdk.tar.xz
sha512: 69c9be39a452c202ebe99fa3a7f31cb9a8028a8413afc344ef80d0f0d41e28c25cc9ad634e24e23639792b19f07d6acc22494429789dde725d8e202fe5625e27
filesize: 156663204

filename: setup.sh.ndk 
sha512: 5aaec0a91da377fb1bf86ac2a28a2adea3d3f7736b71c0fb2249ae8ca0ff66731311f89c9e933f0944e8e5771a0c14d6a3055f181721f52a0cd5397f175bcb14
filesize: 156663204
*correction* filesize of setup.sh.ndk: 217 bytes
Depends on: 979438

Updated

4 years ago
Attachment #8382450 - Flags: review?(mshal) → review+
(Assignee)

Comment 16

4 years ago
Created attachment 8385798 [details] [diff] [review]
894885fixup

this code dupplicates (and overrides!) what's in the common android mozconfig
Attachment #8385798 - Flags: review?(mh+mozilla)
(Assignee)

Comment 17

4 years ago
Created attachment 8385800 [details] [diff] [review]
sdktest
Attachment #8385800 - Flags: review?(mh+mozilla)
Comment on attachment 8385798 [details] [diff] [review]
894885fixup

Review of attachment 8385798 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but i'd actually like more cleanup.

::: mobile/android/config/mozconfigs/android/debug
@@ -18,5 @@
> -fi
> -
> -ac_add_options --with-android-gnu-compiler-version=4.7
> -ac_add_options --with-android-version=9
> -ac_add_options --with-system-zlib

This is duplicated in other mozconfigs, too.

Note the common mozconfig should probably be changed to *not* include the --target, and be included in the x86 mozconfig as well.
Attachment #8385798 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8385800 [details] [diff] [review]
sdktest

Review of attachment 8385800 [details] [diff] [review]:
-----------------------------------------------------------------

With the lack of update of l10n and x86/armv6 mozconfigs in the previous patch, this will fail.
Attachment #8385800 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 20

4 years ago
(In reply to Mike Hommey [:glandium] from comment #18)
> Comment on attachment 8385798 [details] [diff] [review]
> 894885fixup
> 
> Review of attachment 8385798 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+, but i'd actually like more cleanup.
> 
> ::: mobile/android/config/mozconfigs/android/debug
> @@ -18,5 @@
> > -fi
> > -
> > -ac_add_options --with-android-gnu-compiler-version=4.7
> > -ac_add_options --with-android-version=9
> > -ac_add_options --with-system-zlib
> 
> This is duplicated in other mozconfigs, too.

yeah, I only fixed that one because it was the only one to break on try and I forgot about l10n somehow. So I was trying to be conservative but that doesn't actually make any sense.

> Note the common mozconfig should probably be changed to *not* include the
> --target, and be included in the x86 mozconfig as well.

it looks like it *is* included in the x86 mozconfigs, presumably the second --target wins

(In reply to Mike Hommey [:glandium] from comment #19)
> With the lack of update of l10n and x86/armv6 mozconfigs in the previous
> patch, this will fail.

well, it looks like the android-armv6/debug mozconfig is unused given https://tbpl.mozilla.org/?tree=Try&rev=ec94922ca61d but I can't say anything about x86 since I can't spell :(
(Assignee)

Comment 21

4 years ago
Created attachment 8387148 [details] [diff] [review]
894885fixup

still not perfect, but this at least mostly cleans up those other mozconfigs
Attachment #8387148 - Flags: review?(mh+mozilla)
(Assignee)

Updated

4 years ago
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/ea3ad950c01b
The newest Android build tools version has been updated to 19.0.3; our Fennec build docs say we don't support r22 or build-tools-18+, but we could update the best-effort build-tools search[1] to include the new revision.

[1] http://hg.mozilla.org/mozilla-central/file/4f08a24e4fb5/build/autoconf/android.m4#l296
(In reply to Trevor Saunders (:tbsaunde) from comment #21)
> Created attachment 8387148 [details] [diff] [review]
> 894885fixup
> 
> still not perfect, but this at least mostly cleans up those other mozconfigs

glandium, review ping? or suggest another reviewer?
Flags: needinfo?(mh+mozilla)
(Assignee)

Comment 25

4 years ago
(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #24)
> (In reply to Trevor Saunders (:tbsaunde) from comment #21)
> > Created attachment 8387148 [details] [diff] [review]
> > 894885fixup
> > 
> > still not perfect, but this at least mostly cleans up those other mozconfigs
> 
> glandium, review ping? or suggest another reviewer?

arguably the r+ on the previous version  could cary forward since all the changes are what I believe glandium asked for, but I'd be more comfortable with that if you make it explicit that was what you meant.
Comment on attachment 8387148 [details] [diff] [review]
894885fixup

Review of attachment 8387148 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the long wait. I was heads down on something.
r=me with the following addressed.

::: mobile/android/config/mozconfigs/android-armv6/debug
@@ +10,2 @@
>  # Android
>  ac_add_options --target=arm-linux-androideabi

You now have this twice. (note it's better to keep --target and --with-arch close together, so i'd just remove the one you're adding).

::: mobile/android/config/mozconfigs/android-armv6/l10n-nightly
@@ +15,2 @@
>  # Android
>  ac_add_options --target=arm-linux-androideabi

Likewise

::: mobile/android/config/mozconfigs/android-noion/nightly
@@ -37,5 @@
> -# This will overwrite the default of stripping everything and keep the symbol table.
> -# This is useful for profiling with eideticker. See bug 788680
> -STRIP_FLAGS="--strip-debug"
> -
> -. "$topsrcdir/mobile/android/config/mozconfigs/common.override"

In case of unexpected consequences, you may want this to be in a separate patch, so that if the removal needs to be backed out for whatever reason, the rest is not backed out at the same time.

::: mobile/android/config/mozconfigs/android/debug-nonunified
@@ +1,4 @@
>  . "$topsrcdir/mobile/android/config/mozconfigs/android/debug"
>  
> +# Android
> +ac_add_options --target=arm-linux-androideabi

That's already in mobile/android/config/mozconfigs/android/debug

::: mobile/android/config/mozconfigs/android/nightly-nonunified
@@ +1,4 @@
>  . "$topsrcdir/mobile/android/config/mozconfigs/android/nightly"
>  
> +# Android
> +ac_add_options --target=arm-linux-androideabi

This is already in mobile/android/config/mozconfigs/android/nightly
Attachment #8387148 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 27

4 years ago
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/34f2538b1c38
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7bb92c73225e
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/518bca1c6944
https://hg.mozilla.org/mozilla-central/rev/34f2538b1c38
https://hg.mozilla.org/mozilla-central/rev/7bb92c73225e
https://hg.mozilla.org/mozilla-central/rev/518bca1c6944
(Assignee)

Updated

4 years ago
URL: scr
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(bugspam.Callek)
Resolution: --- → FIXED
Whiteboard: [leave open]
Flags: needinfo?(mh+mozilla)
Depends on: 988774

Updated

a year ago
No longer blocks: 702845
You need to log in before you can comment on or make changes to this bug.