Error out when entries in *SOURCES have an unknown file type

RESOLVED FIXED in mozilla28

Status

RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla28
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
As noted in bug 929905 comment 12.
(Assignee)

Comment 1

5 years ago
Created attachment 823723 [details] [diff] [review]
Error out when entries in *SOURCES have an unknown file type
Attachment #823723 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 823751 [details] [diff] [review]
Error out when entries in *SOURCES have an unknown file type

Was using get instead of setdefault. Oops.
Attachment #823751 - Flags: review?(gps)
(Assignee)

Comment 3

5 years ago
Created attachment 823752 [details] [diff] [review]
Error out when entries in *SOURCES have an unknown file type

Was using get instead of setdefault. Oops.
Attachment #823752 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Attachment #823723 - Attachment is obsolete: true
Attachment #823723 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Attachment #823751 - Attachment is obsolete: true
Attachment #823751 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Blocks: 932170

Comment 4

5 years ago
Comment on attachment 823752 [details] [diff] [review]
Error out when entries in *SOURCES have an unknown file type

Review of attachment 823752 [details] [diff] [review]:
-----------------------------------------------------------------

A test would be nice. But I'm in a generous mood this morning.

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +203,2 @@
>          )
> +        for var, map in varmap.items():

Nit: Please don't override the built-in "var" and "map" symbols.

@@ +203,4 @@
>          )
> +        for var, map in varmap.items():
> +            if sandbox[var]:
> +                for f in sandbox[var]:

You can probably just use the for loop since sandbox[var] should return an empty list.
Attachment #823752 - Flags: review?(gps) → review+

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b3aa84e5df45
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.