932133 - Error out when entries in *SOURCES have an unknown file type

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

As noted in bug 929905 comment 12.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Error out when entries in *SOURCES have an unknown file type

Comment 2

[Mike Hommey [:glandium]]

Attachment: Error out when entries in *SOURCES have an unknown file type

Was using get instead of setdefault. Oops.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Error out when entries in *SOURCES have an unknown file type

Was using get instead of setdefault. Oops.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 823752 [details] [diff] [review]
Error out when entries in *SOURCES have an unknown file type

Review of attachment 823752 [details] [diff] [review]:
-----------------------------------------------------------------

A test would be nice. But I'm in a generous mood this morning.

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +203,2 @@
>          )
> +        for var, map in varmap.items():

Nit: Please don't override the built-in "var" and "map" symbols.

@@ +203,4 @@
>          )
> +        for var, map in varmap.items():
> +            if sandbox[var]:
> +                for f in sandbox[var]:

You can probably just use the for loop since sandbox[var] should return an empty list.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3aa84e5df45

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b3aa84e5df45