Closed
Bug 932226
Opened 11 years ago
Closed 11 years ago
[Settings] Lazy load keyboard scripts
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Keywords: perf, Whiteboard: [c= p=1 s= u=])
Attachments
(1 file)
Several keyboard scripts were added to settings startup here: https://github.com/mozilla-b2g/gaia/commit/08901c788a3a4bd3efda5853d7ee9c8f6d04cf50
These are only utilized by keyboard.js currently which is loaded as a subpanel. We should fix some of the performance regression if we lazy load these files.
|
Assignee | |
Comment 1•11 years ago
|
||
Hi Arthur - Anything bad about deferring these scripts until the keyboard panel loads?
Attachment #823921 -
Flags: review?(arthur.chen)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 823921 [details] [review]
Github pull request
It's fine to load them until the keyboard panels loaded. r=me.
Attachment #823921 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks for the review! Landed in master: https://github.com/mozilla-b2g/gaia/commit/8b65283997529014189d603c97fbeb77fbaeb6a7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•