920378 - [1.2] Settings App launch time has regressed (compared to [1.1])

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Mandyam Vikram]

Steps to reproduce:

Launch the Settings App (QRD 7x27 device). Measurements are made using a high speed camera measuring the time from when the touch event was recognized to first app paint.


Actual results on v1.2 Branch(
Gaia version:
c932c482c6944fa32724ce7af9e5423c4c2bcccd
Gecko version:
f98470e4c52dbcd3ee0236d7566df733b89f9fa9):

Measured time on (1.2) is:
1265 ms
Measured time on (1.1):
985 ms


Expected results:

Would expect launch time to be close to 1.1 or better.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+'ing due to bug 916996.

Kevin, could you help?

Comment 2

[Kevin Grandon :kgrandon]

I will take the bug and start investigating. Anyone else is free to chime in in the meantime if they have ideas/patches :)

Comment 4

[Kevin Grandon :kgrandon]

Appears to be a few new javascript files in the settings app that may be impacting this depending on how measurements are being made.

These should not impact raw initial paint time too much, but they would impact preset/form population. Some of the new files include:

shared/js/keyboard_helper.js
shared/js/icc_helper.js
js/mvvm/views.js
js/mvvm/models.js
shared/js/wifi_helper.js

As a part of bug 922658 I am removing code which requires subpanels to be loaded as dependencies. Along those same lines, these files should be moved into their respective panels where possible.

Comment 5

[Mandyam Vikram]

Based on profiling the following build, the Settings app is now on par with v1.1:
Gaia version:
845801e0c74badf0b96657a864935ef1a983cf47
Gecko version:
bbb4c0a8fa65cf1546a6cedc4c20fea16cd63ef2

As such, I'm marking this as not blocking for 1.2. To manage risk, maybe this should be brought in 1.3

Comment 6

[Kevin Grandon :kgrandon]

Removing koi+ per Comment 5.