932235 - new email link icon

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

We need a new email link icon that is different than the share icon, since both may be visible.

Comment 1

[Felix H. Dahlke]

Actually, how bug 879982 is currently implemented, they can't be visible at the same time. Might still make sense to have a separate icon of course.

Comment 2

[Shane Caraveo (:mixedpuppy)]

(In reply to Felix H. Dahlke from comment #1)
> Actually, how bug 879982 is currently implemented, they can't be visible at
> the same time. Might still make sense to have a separate icon of course.

Yeah, I just commented in there.  Sorry to run you in circles, but right now it doesn't make sense to conflate share and email until share also handles the default case that is being added in bug 879982.  So it should be possible for both buttons to be enabled.

Comment 3

[u428464]

Note that current implementation does not only change icon direction but also text in overflow mode. When the new icon ships it mus be ensured that the text is right again in overflow.

Comment 5

[Tim Nguyen :ntim]

I guess some kind of envelop icon would be nice. Might make a concept icon.

Comment 6

[Tim Nguyen :ntim]

Attachment: Compose style icon (Windows 8 inverted)

I know some kind of mail icon would be preferred, but this icon is similar to a compose mail icon. Posting a black icon after this one.

Comment 7

[Tim Nguyen :ntim]

Attachment: Compose mail style icon (black glyph)

This is not really Firefoxy looking, but it's still useful right ?

Comment 8

[Tim Nguyen :ntim]

Attachment: Envelope icon (Windows 8)

This

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8347754 [details]
Envelope icon (Windows 8)

Sorry, end of the description :
This is an envelope style icon. It's made for Windows 8.
If you need a black glyph, just ask.

Comment 12

[u428464]

I think Mike Maslaney is in charge of the icons now.

Comment 15

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Email_Icon.zip

Email icon attached to the global menuPanel and toolbars sprite sheet.

Comment 17

[Stephen Horlander [:shorlander]]

Attachment: Fix Email Icon - 01

Remove transforms to flipped Shareplane. Adds new email icon.

Comment 18

[Jared Wein [:jaws] (please needinfo? me)]

Needs [Australis] in the commit message, but this can be checked in.

Comment 19

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/df246336a9ab

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df246336a9ab

Comment 21

[:Gijs (out for now; he/him)]

This icon disappears on OS X retina when clicked.

Comment 22

[:Gijs (out for now; he/him)]

Attachment: Australis' email link icon disappears,

I apologize for the weirdest diff I've ever seen. I only touched the email link icon rules, but instead of moving those it's moved a bunch of other stuff around it...

Comment 23

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8369189 [details] [diff] [review]
Australis' email link icon disappears,

Review of attachment 8369189 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, that is a weird diff. It looks like you just moved the rules so that they would be in sprite-sheet order.

Comment 24

[:Gijs (out for now; he/him)]

(In reply to Jared Wein [:jaws] from comment #23)
> Comment on attachment 8369189 [details] [diff] [review]
> Australis' email link icon disappears,
> 
> Review of attachment 8369189 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Yes, that is a weird diff. It looks like you just moved the rules so that
> they would be in sprite-sheet order.

Aye. And updated the rect()s but yeah. No idea why diff did something that weird. Diff -w wasn't any better.

Anyway, landed: remote:   https://hg.mozilla.org/integration/fx-team/rev/9d4c8dac03fa

Comment 25

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9d4c8dac03fa