Closed Bug 932270 Opened 8 years ago Closed 7 years ago

[B2G][L10n] AM/PM should be also localizable

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S2 (28feb)
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: petercpg, Assigned: flod)

References

Details

(Keywords: l12y, Whiteboard: LocRun1.3)

Attachments

(2 files)

Build ID: 20131025225454
Gaia: 2ad615234dfde72b69bd4ac397e6dd898076bcab
Platform Version: 26.0a2

We should have AM/PM localizable in order to localize time-picking reels.
Still affects 1.3. Please aware the order of AM/PM and time as well. 

Device: Geeksphone Keon
Build: 20140205010019
Gaia: 3405205
Platform Version: 28.0
Summary: [L10n] AM/PM non-localizable → [B2G][L10n] AM/PM should be also localizable
Whiteboard: LocRun1.3
Attached image Local test
Quick local test on Keon, using XM/YM instead of AM/PM
Assignee: nobody → francesco.lodolo
Kaze, any news on this? Do you think we should take a different approach?
Putting Kaze in needinfo (niark niark) :)
Flags: needinfo?(kaze)
Comment on attachment 8372086 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16068

Thanks for the heads-up Delphine. :-)

It took me a while (we’re urged to ignore all non-blocking bugs these days), but yes, I’m OK with this approach.

Please open a follow-up to fix the homescreen clock as well. It should be similar (though simpler) to bug 932356: I think we should rely on the position of `%p' in the `shortTimeFormat' entity to properly order the time and am/pm strings.

Another nice follow-up could be to check all shortTimeFormat-like entities in Gaia. I think we have a lot of duplicates which are not always consistent — especially for zh-TW, where there are both `%I:%M %p' and `%p %I:%M' — and I think we should always reuse the default string (defined in shared/locales/date) to ensure consistency.
Attachment #8372086 - Flags: review?(kaze) → review+
Flags: needinfo?(kaze)
Thanks kaze, I'll take a look later today at both (home page clock and consistency).

Setting checkin-needed to get this landed.
Keywords: checkin-needed
Master: 5decee8a091062b2923fdc5e6229beb1d4db7f85
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in before you can comment on or make changes to this bug.