Status

Webtools
Pulse
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mcote, Assigned: mcote)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We need to add a simple message type to mozillapulse for generic bug changes produced by the new simple push extension (bug 932346).
(Assignee)

Updated

5 years ago
Blocks: 932353
(Assignee)

Comment 1

5 years ago
Created attachment 826082 [details] [diff] [review]
SimpleBugMessage consumer, publisher, and message type.

This is intended primarily for the Bugzilla Change Notification System,
with messages being published by Bugzilla's PushNotify extension.
(Assignee)

Comment 2

5 years ago
Created attachment 826103 [details] [diff] [review]
Publisher, consumer, and message type

This implements a SimpleBugzillaMessage for the notifications generated by the PushNotify Bugzilla extension. Also tidied up a couple little things.
Attachment #826103 - Flags: review?(dkl)
(Assignee)

Updated

5 years ago
Attachment #826082 - Attachment is obsolete: true
(Assignee)

Comment 3

5 years ago
Hm sorry for the double post; bzexport was acting strangely.
(Assignee)

Comment 4

5 years ago
Comment on attachment 826103 [details] [diff] [review]
Publisher, consumer, and message type

Giving this to jgriffin just because dkl has a lot on his plate right now.
Attachment #826103 - Flags: review?(dkl) → review?(jgriffin)
Comment on attachment 826103 [details] [diff] [review]
Publisher, consumer, and message type

Review of attachment 826103 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozillapulse/messages/bugzilla.py
@@ +17,5 @@
> +        tmp.append('delta_ts')
> +        return tmp
> +
> +    def set(self, bug_id, delta_ts):
> +        self.routing_parts = [str(bug_id)]

Frequently, routing keys contain a verb (like '852154.updated').  If there's the possibility that other notification types may be added in the future (like 'comment_added' or 'attachments_updated'), it might make sense to add a verb to the key now.

But, I know you said you may be adding a master 'give me any type of change' API, so maybe this won't ever be needed.
Attachment #826103 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 6

5 years ago
I don't think it's necessary; the whole design is based around the idea of a minimal notification, so we would never be giving details as to what has changed.  I think you were confusing my comments as to having a single API call to find out what changed, but that is completely separate from the Pulse messages; it's intended to simplify the process *after* a notification is received, when we do all the normal security checks and such.  If we ever go back to adding more info, for say public bugs only, we can go back to the original Bugzilla Pulse messages.

https://hg.mozilla.org/automation/mozillapulse/rev/8fe69736dc9f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.