932353 - Pulse shim for Bugzilla Change Notification Service

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Bugzilla Change Notification System, defect)

Description

[Mark Côté [:mcote]]

The complement of bug 932346 is a simple application which reads bug-change entries from the table, publishes pulse messages (as per bug 932352), and then deletes the entries (assuming the publication succeeded).

Comment 1

[Mark Côté [:mcote]]

Attachment: bug-932353.diff

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 830483 [details] [diff] [review]
bug-932353.diff

Review of attachment 830483 [details] [diff] [review]:
-----------------------------------------------------------------

::: bugzilla_simple_shim.py
@@ +22,5 @@
> +
> +from mozillapulse.messages.bugzilla import SimpleBugMessage
> +from mozillapulse.publishers import SimpleBugzillaPublisher
> +
> +cfg = ConfigParser.ConfigParser()

This can just go inside main(), I think.

@@ +73,5 @@
> +    if os.path.exists(lockfile):
> +        print 'Bugzilla simple shim is already running.'
> +        return 0
> +
> +    file(lockfile, 'w').close()

This should be moved to before the last try block, in order to avoid an orphaned lockfile if one of the options causes an abort.

Comment 3

[Mark Côté [:mcote]]

Made suggested changes and changed file() to open() as per standard Python usage.

https://hg.mozilla.org/automation/pulseshims/rev/07fb4923e8a6