Closed Bug 932353 Opened 6 years ago Closed 6 years ago

Pulse shim for Bugzilla Change Notification Service

Categories

(bugzilla.mozilla.org Graveyard :: Bugzilla Change Notification System, defect)

Development
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

References

Details

Attachments

(1 file)

The complement of bug 932346 is a simple application which reads bug-change entries from the table, publishes pulse messages (as per bug 932352), and then deletes the entries (assuming the publication succeeded).
Attached patch bug-932353.diffSplinter Review
Attachment #830483 - Flags: review?(jgriffin)
Comment on attachment 830483 [details] [diff] [review]
bug-932353.diff

Review of attachment 830483 [details] [diff] [review]:
-----------------------------------------------------------------

::: bugzilla_simple_shim.py
@@ +22,5 @@
> +
> +from mozillapulse.messages.bugzilla import SimpleBugMessage
> +from mozillapulse.publishers import SimpleBugzillaPublisher
> +
> +cfg = ConfigParser.ConfigParser()

This can just go inside main(), I think.

@@ +73,5 @@
> +    if os.path.exists(lockfile):
> +        print 'Bugzilla simple shim is already running.'
> +        return 0
> +
> +    file(lockfile, 'w').close()

This should be moved to before the last try block, in order to avoid an orphaned lockfile if one of the options causes an abort.
Attachment #830483 - Flags: review?(jgriffin) → review+
Made suggested changes and changed file() to open() as per standard Python usage.

https://hg.mozilla.org/automation/pulseshims/rev/07fb4923e8a6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: General → Bugzilla Change Notification System
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.