932694 - about:apps is empty after closing Firefox

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: LG Nexus 4
OS: Android 4.2.2

Steps to Reproduce:
1. Install a web application by visiting the Mozilla Marketplace
2. Close Firefox( swipe it from the Task Manager or 'Force Stop' from Settings)
3. Open Firefox and go to about:apps

Expected result:
- The installed app should appear in the list

Actual Result:
- about:apps is blank

Comment 1

[Teodora Vermesan (:TeoVermesan)]

Please see video: https://www.youtube.com/watch?v=lBQwgH3u7_4

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Adding Margaret in case bug 880281 somehow affected this

Comment 3

[Aaron Train [:aaronmt]]

Please find a regression-window.

Comment 4

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Adding Margaret in case bug 880281 somehow affected this

I'm suspicious that it did, we may be failing to set an attribute on that container correctly to make it show up. I'll investigate.

Comment 5

[:Margaret Leibovic]

This was caused by bug 880281.

Comment 6

[:Margaret Leibovic]

Attachment: patch

This fixes the problem, but I'm not really happy with it because there's a janky delay for the container to show up. I contemplated making it visible by default then hiding it if there are no apps, but then there's jankiness when no apps are installed.

I think a follow-up could be to add a transition to make this appear more smoothly.

I also found another bug where the #main-container element is wider than the viewport, and I found that was caused by the .list rule for width:100%. I found that we don't actually need any of the .list styles for this container, so I just removed that class to fix the issue.

Comment 7

[:Margaret Leibovic]

We should track 27, since this is a regression there.

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/ac77f56f732f

Comment 9

[:Margaret Leibovic]

Comment on attachment 824813 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 880281
User impact if declined: installed apps aren't visible on about:apps
Testing completed (on m-c, etc.): just pushed to fx-team
Risk to taking this patch (and alternatives if risky): low risk, fixing mistake that updates the way an attribute is set
String or IDL/UUID changes made by this patch: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ac77f56f732f

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac77f56f732f

Comment 12

[u421692]

Verified as fixed on LG Nexus 4(Android 4.2.2), Nightly 28.0a1 (2013-11-03).

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c24b1290afa9

Comment 14

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 28.0a1 (2013-12-01) and Firefox for Android 27.0a2 (2013-12-01)
Device: LG Nexus 4
OS: Android 4.2.2