Closed Bug 933047 Opened 8 years ago Closed 8 years ago

configure should fail if CXX can't link C++ executables

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: mshal, Assigned: glandium)

References

Details

Attachments

(2 files, 2 obsolete files)

While trying to setup a cross compile, I inadvertently set CXX to be 'clang' instead of 'clang++' in my mozconfig. The configure step still passed, but the build failed later when trying to link a C++ executable because it wasn't using the right libraries. It would be nice if configure would check to make sure that CXX is actually capable of linking properly.
Does this look somewhat appropriate? It seems to correctly flag CXX=clang in the mozconfig as invalid, though I have to rm -rf objdir when I change CXX.
Attachment #824986 - Flags: feedback?(mh+mozilla)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 824986 [details] [diff] [review]
0001-Bug-933047-WIP.patch

This is roughly what i did, at a different level with a different test code.
Attachment #824986 - Flags: feedback?(mh+mozilla)
Missing AC_MSG_RESULTs
Attachment #824999 - Flags: review?(ted)
Attachment #824987 - Attachment is obsolete: true
Attachment #824987 - Flags: review?(ted)
Attachment #824999 - Flags: review?(ted) → review+
sigh. the test doesn't work with MSVC. OTOH, we do have a specific similar test for MSVC already in configure.in.
This fixes it. The fixup is trivial enough to not rerequest review.
Attachment #824999 - Attachment is obsolete: true
Attachment #825103 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/cb728c8c416e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Product: Core → Firefox Build System
Depends on: 1458954
You need to log in before you can comment on or make changes to this bug.