Closed Bug 933072 Opened 7 years ago Closed 7 years ago

Make test_Range-cloneContents.html , test_Range-deleteContents.html and test_Range-extractContents.html only create a small number of <iframe>s

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
firefox28 --- fixed
firefox-esr24 --- wontfix
b2g-v1.2 --- fixed

People

(Reporter: roc, Assigned: roc)

References

Details

(Whiteboard: ]qa-])

Attachments

(1 file)

These tests create hundreds of <iframe>s. Let's not do that.
If you'd like.  It would make it easier to see if this has been fixed for realz.
roc: if this sticks, please upstream the changes.
Flags: needinfo?(roc)
IIRC, I did it in parallel originally to reduce the amount of time the test takes (obviously at the expense of memory).  Does this change make the tests take longer to run?  It might be worth it for memory savings, but still good to know.
> Does this change make the tests take longer to run?
From TBPL, it looks like M2 Win7 debug takes about 18 minutes, with or without this patch, so there's no huge increase in test time.

This should also get landed on Aurora, which is having the same M2 problem.
I have it on my todo list to get as many of the applicable fixes uplifted up the line as far as possible once m-c is reopened. I can assure you this will not be forgotten :)
(In reply to :Ms2ger from comment #7)
> roc: if this sticks, please upstream the changes.

https://github.com/w3c/web-platform-tests/pull/397
Flags: needinfo?(roc)
(In reply to :Aryeh Gregor from comment #8)
> IIRC, I did it in parallel originally to reduce the amount of time the test
> takes (obviously at the expense of memory).  Does this change make the tests
> take longer to run?  It might be worth it for memory savings, but still good
> to know.

My guess is these changes make the tests run faster. Setting up all those frames, windows, documents etc and blowing out memory takes a lot of time :-).
https://hg.mozilla.org/mozilla-central/rev/b71c156e7307
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Blocks: 929359
26 is also affected I think, but file moves will make it more of a pain to uplift, so let's just land on aurora.
Whiteboard: ]qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.