933072 - Make test_Range-cloneContents.html , test_Range-deleteContents.html and test_Range-extractContents.html only create a small number of <iframe>s

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

These tests create hundreds of <iframe>s. Let's not do that.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b71c156e7307

Comment 3

[Andrew McCreight [:mccr8]]

Yay!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Should https://hg.mozilla.org/integration/mozilla-inbound/rev/33c9ee1b4564 be backed out then?

Comment 5

[Andrew McCreight [:mccr8]]

If you'd like.  It would make it easier to see if this has been fixed for realz.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

What could possibly go wrong.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba5c76b30f29

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

roc: if this sticks, please upstream the changes.

Comment 8

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

IIRC, I did it in parallel originally to reduce the amount of time the test takes (obviously at the expense of memory).  Does this change make the tests take longer to run?  It might be worth it for memory savings, but still good to know.

Comment 9

[Andrew McCreight [:mccr8]]

> Does this change make the tests take longer to run?
From TBPL, it looks like M2 Win7 debug takes about 18 minutes, with or without this patch, so there's no huge increase in test time.

This should also get landed on Aurora, which is having the same M2 problem.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

I have it on my todo list to get as many of the applicable fixes uplifted up the line as far as possible once m-c is reopened. I can assure you this will not be forgotten :)

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to :Ms2ger from comment #7)
> roc: if this sticks, please upstream the changes.

https://github.com/w3c/web-platform-tests/pull/397

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to :Aryeh Gregor from comment #8)
> IIRC, I did it in parallel originally to reduce the amount of time the test
> takes (obviously at the expense of memory).  Does this change make the tests
> take longer to run?  It might be worth it for memory savings, but still good
> to know.

My guess is these changes make the tests run faster. Setting up all those frames, windows, documents etc and blowing out memory takes a lot of time :-).

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b71c156e7307

Comment 14

[Ed Morley [:emorley]]

26 is also affected I think, but file moves will make it more of a pain to uplift, so let's just land on aurora.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/05c6a164f95a
https://hg.mozilla.org/releases/mozilla-beta/rev/201cf3649001

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/201cf3649001