Closed Bug 933072 Opened 7 years ago Closed 7 years ago
_Range-clone Contents .html , test _Range-delete Contents .html and test _Range-extract Contents .html only create a small number of <iframe>s
These tests create hundreds of <iframe>s. Let's not do that.
Attachment #825052 - Flags: review?(khuey) → review+
Should https://hg.mozilla.org/integration/mozilla-inbound/rev/33c9ee1b4564 be backed out then?
If you'd like. It would make it easier to see if this has been fixed for realz.
What could possibly go wrong. https://hg.mozilla.org/integration/mozilla-inbound/rev/ba5c76b30f29
roc: if this sticks, please upstream the changes.
IIRC, I did it in parallel originally to reduce the amount of time the test takes (obviously at the expense of memory). Does this change make the tests take longer to run? It might be worth it for memory savings, but still good to know.
> Does this change make the tests take longer to run? From TBPL, it looks like M2 Win7 debug takes about 18 minutes, with or without this patch, so there's no huge increase in test time. This should also get landed on Aurora, which is having the same M2 problem.
I have it on my todo list to get as many of the applicable fixes uplifted up the line as far as possible once m-c is reopened. I can assure you this will not be forgotten :)
(In reply to :Ms2ger from comment #7) > roc: if this sticks, please upstream the changes. https://github.com/w3c/web-platform-tests/pull/397
(In reply to :Aryeh Gregor from comment #8) > IIRC, I did it in parallel originally to reduce the amount of time the test > takes (obviously at the expense of memory). Does this change make the tests > take longer to run? It might be worth it for memory savings, but still good > to know. My guess is these changes make the tests run faster. Setting up all those frames, windows, documents etc and blowing out memory takes a lot of time :-).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
26 is also affected I think, but file moves will make it more of a pain to uplift, so let's just land on aurora.
You need to log in before you can comment on or make changes to this bug.