Closed Bug 933141 Opened 6 years ago Closed 5 years ago

[NFC] Move NFC files out of system/gonk

Categories

(Firefox OS Graveyard :: NFC, defect)

x86_64
Linux
defect
Not set

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
tracking-b2g backlog

People

(Reporter: dgarnerlee, Assigned: allstars.chh)

References

Details

Attachments

(1 file)

NFC is not strictly a FirefoxOS only feature, although it is currently developed as one.

This bug tracks moving NFC out of gecko/dom/system/gonk and into gecko/dom/nfc instead.
Depends on: webnfc
Please this into backlog.
blocking-b2g: --- → backlog
Assignee: nobody → allstars.chh
Attached patch PatchSplinter Review
I'll ask r? for gps once Dimi reviewed this.
Attachment #8466104 - Flags: review?(dlee)
Summary: [NFC] Move NFC Chromeworker out of system/gonk → [NFC] Move NFC files out of system/gonk
Comment on attachment 8466104 [details] [diff] [review]
Patch

Please note the rename part which isn't showed in Bugzilla

diff --git a/dom/system/gonk/NfcContentHelper.js b/dom/nfc/NfcContentHelper.js
rename from dom/system/gonk/NfcContentHelper.js
rename to dom/nfc/NfcContentHelper.js
diff --git a/dom/system/gonk/Nfc.js b/dom/nfc/gonk/Nfc.js
rename from dom/system/gonk/Nfc.js
rename to dom/nfc/gonk/Nfc.js
diff --git a/dom/system/gonk/Nfc.manifest b/dom/nfc/gonk/Nfc.manifest
rename from dom/system/gonk/Nfc.manifest
rename to dom/nfc/gonk/Nfc.manifest
diff --git a/dom/system/gonk/NfcGonkMessage.h b/dom/nfc/gonk/NfcGonkMessage.h
rename from dom/system/gonk/NfcGonkMessage.h
rename to dom/nfc/gonk/NfcGonkMessage.h
diff --git a/dom/system/gonk/NfcMessageHandler.cpp b/dom/nfc/gonk/NfcMessageHandler.cpp
rename from dom/system/gonk/NfcMessageHandler.cpp
rename to dom/nfc/gonk/NfcMessageHandler.cpp
diff --git a/dom/system/gonk/NfcMessageHandler.h b/dom/nfc/gonk/NfcMessageHandler.h
rename from dom/system/gonk/NfcMessageHandler.h
rename to dom/nfc/gonk/NfcMessageHandler.h
diff --git a/dom/system/gonk/NfcOptions.h b/dom/nfc/gonk/NfcOptions.h
rename from dom/system/gonk/NfcOptions.h
rename to dom/nfc/gonk/NfcOptions.h
diff --git a/dom/system/gonk/NfcService.cpp b/dom/nfc/gonk/NfcService.cpp
rename from dom/system/gonk/NfcService.cpp
rename to dom/nfc/gonk/NfcService.cpp
diff --git a/dom/system/gonk/NfcService.h b/dom/nfc/gonk/NfcService.h
rename from dom/system/gonk/NfcService.h
rename to dom/nfc/gonk/NfcService.h
diff --git a/dom/system/gonk/nfc_consts.js b/dom/nfc/gonk/nfc_consts.js
rename from dom/system/gonk/nfc_consts.js
rename to dom/nfc/gonk/nfc_consts.js
diff --git a/dom/system/gonk/nsINfcService.idl b/dom/nfc/gonk/nsINfcService.idl
rename from dom/system/gonk/nsINfcService.idl
rename to dom/nfc/gonk/nsINfcService.idl
diff --git a/dom/nfc/moz.build b/dom/nfc/moz.build
Attachment #8466104 - Flags: review?(dlee)
Attachment #8466104 - Flags: review?(dlee) → review+
Comment on attachment 8466104 [details] [diff] [review]
Patch

r? to gps for the moz.build changes.
Attachment #8466104 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/0c92a029fc21
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
For future reference, changes like this do need review from a DOM peer. Retrospective r=jst for this one.
(In reply to Johnny Stenback  (:jst, jst@mozilla.com) from comment #8)
> For future reference, changes like this do need review from a DOM peer.
> Retrospective r=jst for this one.

Hi Johnny
Sorry I don't know I have to ask review from a DOM peer for this.
When these files are created they weren't reviewed by a DOM peer either. 
https://hg.mozilla.org/mozilla-central/rev/0e930ae50509

Can you explain more detail why this also needs a DOM peer review?
Is it because this patch creates an extra folder 'dom/nfc/gonk'?
I just want to be sure what kinds of change should be reviewed by DOM peer, and what changes should be reviewed by a Build Peer.

BTW, is my patch causing any trouble?
if so, please tell me and I'll fix it.

Thanks
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.