933380 - shell.getContentWindow is undefined when trying to remotely close an app

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Alexandre Poirot [:ochameau]]

Bug 924032 regressed the support for remote app closing by using shell.getContentWindow() instead of getContentWindow().
Hopefully we will get that unitested soon.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Fix exception on app close request

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Fix exception on app close request

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/82546b96471c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82546b96471c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/82546b96471c

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 825450 [details] [diff] [review]
Fix exception on app close request

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 924032
User impact if declined: Stop action will be broken in app manager
Testing completed (on m-c, etc.): Locally and baked on master a few days.
Risk to taking this patch (and alternatives if risky): limited, only devtools codepath
String or IDL/UUID changes made by this patch: none.

As bug 924032 was uplifted to 1.2, we need to also uplift this to fix its regression.

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 825450 [details] [diff] [review]
Fix exception on app close request


[Triage Comment]
also approving for aurora (27) uplift since we'll want to cover the bases there, assuming you can land this there as-is.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/52b2f1c08ae2
https://hg.mozilla.org/releases/mozilla-beta/rev/3cc5e2a6780d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/3cc5e2a6780d

Comment 10

[Petruta Horea [:phorea]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0

The issue still reproduces on Fx 26 beta 7 (20131122094025), latest Aurora (20131125004001) and latest Nightly (20131124104839) when Firefox OS 1.2 Simulator is used - the apps are not stopped.

With Firefox OS 1.3 Simulator and an unagi device with 1.3.0.0-prerelease the issue doesn't reproduce on latest Firefox versions, but today I couldn't reproduced it also on the Nighlty builds from October (when the bug was filled). I have tried with default, hosted and packaged apps.

I remember noticing this issue on device in October and email Paul Rouget about it, he told me when it was fixed and I confirmed it was fixed. I don't understand why now the original issue is not reproducible on those builds.
Alexandre, do you have any suggestions? Thank you

Comment 11

[Alexandre Poirot [:ochameau]]

Simulator 1.2 builds are based on a gecko version of the 28th, so it doesn't contains the patch that landed on 6th of Nomvember.
I'll spawn new xpi right now.

Comment 12

[Petruta Horea [:phorea]]

Verified as fixed on Fx 26 beta 8 (20131125215016), latest Aurora and latest Nightly on Win 7 64-bit, Ubuntu 13.04 64-bit and Mac OS X 10.8.5.

However, on an unagi device with Fx Os 1.2.0.0-prerelease, the issue still occurs, the apps aren't stopped, no matter what OS or Fx versions are used.

Comment 13

[Petruta Horea [:phorea]]

The issue described in comment 12 is no longer reproducible. Removing the verifyme keyword.