933502 - Make memory reporter mochitests work with ASAN.

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Nicholas Nethercote [inactive]]

Bug 899504 disabled two memory reporter mochitests on ASAN builds.  It's
actually not hard to make them work with ASAN, and doing so simplifies the
build system.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Make memory reporter mochitests work with ASAN.

gps, the changes to the tests themselves won't mean much to you, and I'm happy
for you to rubber-stamp them.  Basically, ASAN builds use enormous amounts of
virtual memory, and the tests just need to handle that.

It's the build system changes that need more careful checking.  In particular,
remote.xul is not a standalone test, but a file that is used by
test_memoryReporters2.xul.  Is |support-files| the right place for it?

This patch was green on try:
https://tbpl.mozilla.org/?tree=Try&rev=4e89a6b81b11

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 825579 [details] [diff] [review]
Make memory reporter mochitests work with ASAN.

Review of attachment 825579 [details] [diff] [review]:
-----------------------------------------------------------------

Covers just the build bits. While the test changes do appear trivial, I'm not a domain expert and don't feel comfortable granting r+.

FWIW, you don't need build peer review for changes like this.

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41d4831fc39d

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41d4831fc39d