933898 - [Camera] 1.3 Visual refresh of Heads Up Display (flash and front/rear toggle buttons)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Peter La]

Add functionality for toggling between flash modes:
Flash: On, Flash: Off, Flash: Auto

User Story:

Media 64
As a user, I like to see flash (on, off, auto) as a camera setting.

Version 0.5 Camera Spec:
https://app.box.com/files/0/f/1211601585/1/f_11402480095

Comment 1

[Peter La]

Attachment: _Camera1_VisualSpec-FlashV1_Nov5.png

This is the visual spec for the Flash toggle functionality.

Diego, please let me know if you need clarification on any item.

Comment 2

[Diego Marcos [:dmarcos]]

Where can I find the icon?

Comment 3

[Peter La]

The icons were exported as part of the zip file attached to the overall refresh bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=933893

Comment 4

[Tiffanie Shakespeare [:tif]]

Comment on attachment 827483 [details]
_Camera1_VisualSpec-FlashV1_Nov5.png

Something I just realized that isn't specified here or in my spec is what happens to the text when in landscape. Do we assume it would be directly to the left or right of the icon?

Comment 5

[Wilson Page]

(In reply to Tiffanie Shakespeare from comment #4)
> Comment on attachment 827483 [details]
> _Camera1_VisualSpec-FlashV1_Nov5.png
> 
> Something I just realized that isn't specified here or in my spec is what
> happens to the text when in landscape. Do we assume it would be directly to
> the left or right of the icon?

The flash icon will remain in the top left whether the screen is in landscape or portrait, so I assume the text will be to the right of the icon at all times.

Comment 6

[Tiffanie Shakespeare [:tif]]

(In reply to Wilson Page from comment #5)
> (In reply to Tiffanie Shakespeare from comment #4)
> > Comment on attachment 827483 [details]
> > _Camera1_VisualSpec-FlashV1_Nov5.png
> > 
> > Something I just realized that isn't specified here or in my spec is what
> > happens to the text when in landscape. Do we assume it would be directly to
> > the left or right of the icon?
> 
> The flash icon will remain in the top left whether the screen is in
> landscape or portrait, so I assume the text will be to the right of the icon
> at all times.

It's true, the icon remains in the same place on screen no matter the phone orientation. In portrait, the icon is in the top left. When rotating counter clockwise to landscape, this relatively puts the icon in the bottom left with the text still written to the right. But when rotating clockwise, this puts the icon in the top right. 

Since there's no room to the right of the icon for the text, I'm guessing we would put the text to the left of the icon instead of below the icon. Sorry I wasn't more clear with my comments. 

Is this correct Peter? I think either you or I should outline this in a spec to ensure everyone is on the same page.

Comment 7

[Wilson Page [:wilsonpage]]

Ahhhh, I completely understand now, sorry. I got confused because the camera app orientation is locked. Yes, I would assume the text should flip to the left hand side when necessary :)

Comment 8

[Wilson Page [:wilsonpage]]

Attachment: Pull Request

Comment 9

[Diego Marcos [:dmarcos]]

Patch looks good to me

Comment 11

[Peter La]

Yes that makes sense.