Closed
Bug 933944
Opened 11 years ago
Closed 11 years ago
rules.html has race condition
Categories
(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)
Release Engineering Graveyard
Applications: Balrog (frontend)
x86_64
Linux
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
|
3.84 KB,
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Rail discovered this today when re-enabling Aurora updates. If you click "update" on one rule, and then "update" on another rule before the first update finishes, you will end up updating the second rule. This is because there's only one form for all of the existing rules, and clicking on "Update" sets the "rule_id" value of the form, which is read in the Javascript that does the update.
We may need to use a separate form for each rule, or perhaps just pass rule_id to submitRuleForm (rather than passing the ruleForm itself).
|
Assignee | |
Comment 1•11 years ago
|
||
I wasn't able to reproduce this locally, but I'm pretty sure this should fix the problem...
|
||
Updated•11 years ago
|
Attachment #8364426 -
Flags: review?(rail) → review+
|
||
Comment 2•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog
https://github.com/mozilla/balrog/commit/244e39909785d1103977ac0ad650558885905225
bug 933944: rules.html has race condition. r=rail
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8364426 -
Flags: checked-in+
|
|
Assignee | |
Comment 3•11 years ago
|
||
This patch is in production, and I wasn't able to repro the problem when I was testing against aus4-admin-dev. I'm pretty sure this is fixed...
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•