The default bug view has changed. See this FAQ.

rules.html has race condition

RESOLVED FIXED

Status

Release Engineering
Balrog: Frontend
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Rail discovered this today when re-enabling Aurora updates. If you click "update" on one rule, and then "update" on another rule before the first update finishes, you will end up updating the second rule. This is because there's only one form for all of the existing rules, and clicking on "Update" sets the "rule_id" value of the form, which is read in the Javascript that does the update.

We may need to use a separate form for each rule, or perhaps just pass rule_id to submitRuleForm (rather than passing the ruleForm itself).
(Assignee)

Updated

3 years ago
Blocks: 596831
(Assignee)

Comment 1

3 years ago
Created attachment 8364426 [details] [diff] [review]
try to fix rules race

I wasn't able to reproduce this locally, but I'm pretty sure this should fix the problem...
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8364426 - Flags: review?(rail)
Attachment #8364426 - Flags: review?(rail) → review+

Comment 2

3 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/244e39909785d1103977ac0ad650558885905225
bug 933944: rules.html has race condition. r=rail
(Assignee)

Updated

3 years ago
Attachment #8364426 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Depends on: 964396
(Assignee)

Comment 3

3 years ago
This patch is in production, and I wasn't able to repro the problem when I was testing against aus4-admin-dev. I'm pretty sure this is fixed...
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.