934023 - UX, OS X: window buttons and fullscreen button wiggle or squish when resizing window or exiting fullscreen mode

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[:Gijs (he/him)]

Attachment: Screencast

See screencast.

Happens as of Nov. 1st nightly (first nightly with the window buttons moved). 

Apologies for the not-so-great-screencast, but it's late and I'm fighting Maverick's new quicktime screencasting and can't be bothered. The effect is still pretty visible. Wonder if this is maverick-specific. Can people reproduce on older versions of OS X?

Comment 1

[Matthew N. [:MattN]]

I also noticed the overlapping/squished controls on Mavericks but I don't remember if I had resized the window first. They didn't redraw properly until I hovered over the buttons and even then there was graphical corruption above the window controls.

Comment 2

[Markus Stange [:mstange]]

I can reproduce on 10.8.

Comment 3

[(no longer active)]

Bug 940134 has a simple test case.

Comment 4

[Markus Stange [:mstange]]

Attachment: patch

I should have realized this when we started using [cell drawWithFrame:inView:] instead of [view drawRect:] for drawing the window buttons - the rects we pass here have different meanings. In drawRect, the rect can be any subrect of the view's bounds, and the view will then only draw the parts of itself that intersect with this subrect, but it won't change its appearance based on the rect. With drawWithFrame, however, the rect describes the whole size of the cell, so making it smaller will squish the contents or make them overflow. When we only want to draw a subrect of a cell, we need to use a clip on the drawing context.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8335286 [details] [diff] [review]
patch

Nice catch!

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

FWIW, I saw this same issue after a restart to my first Nightly build with Australis. Granting focus to the window caused the buttons to redraw as expected.

Comment 9

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3caa5f7ef94f

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3caa5f7ef94f