934212 - Session restore fails to restore all tabs in latest nightly builds

Status: RESOLVED DUPLICATE of bug 933587

(Firefox :: Session Restore, defect)

Description

[Leen Besselink]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131102080838

Steps to reproduce:

There have always been problems restoring some tabs in Firefox, but with the latest Nightly versions it got worse (so problem probably started 2 or 3 nightlies ago).

First time I lost some tabs I did a restart because of an upgrade, because it's the nightly version.

Later I did some restarts myself (I have session restore enabled) and every time I do it I get less and less tabs that opened. The tab is still there, the content is gone, worse so is the URL.


Actual results:

The windows are all still there, the tabs and address bar are both empty. On some tabs the right icon does appear.

On some windows non of the tabs are restored, on many windows only the previously active tab isn't restored.

I made a new profile to test it and with just 1 window things seem to work pretty good, when I have 2 windows, not all tabs are restored.

Not really sure what the pattern is, maybe it's just timing related.

With 2 windows most of the time I get:
active window: all tabs restored
not-active window: all tabs restored, except for the active tab


Expected results:

All tabs should be restored.

Comment 1

[Leen Besselink]

I did some more testing: it's probably not the active window which always has all tabs restored, it's probably the first window in the session.

Comment 2

[Alice0775 White]

I can reproduce the problem

Steps To reproduce(for example):
1. Open several tabs
     [A1]   https://developer.mozilla.org/en-US/docs/Code_snippets
     [A2]   https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Reserved_Words?redirectlocale=en-US&redirectslug=JavaScript%2FReference%2FReserved_Words
     [A3]   https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/26/Site_Compatibility

2. Open New Window(Ctrl+N) say [window B]
3. Open several tabs
     [B1]   https://developer.mozilla.org/en-US/docs/Code_snippets
     [B2]   https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Reserved_Words?redirectlocale=en-US&redirectslug=JavaScript%2FReference%2FReserved_Words
     [B3]   https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/26/Site_Compatibility
     --- Now [B3] is foreground selected tab

4. Exit Browser(Alt > File > Exit)

5. Start Firefox
6. Restore Previous Session
   --- Observe Tabs

7. Repeat from Step.4 if the problem do not happen

Actual Results:
Some of tabs in [window B] fail to restore.

Expected Results:
All tabs should be restored.

Comment 3

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/753a91f79d6f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131031170043
Bad:
http://hg.mozilla.org/mozilla-central/rev/4813677c42bf
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131031180143
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=753a91f79d6f&tochange=4813677c42bf


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f31dc2d87066
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131029083153
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/8cf03e0f7672
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131029084616
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f31dc2d87066&tochange=8cf03e0f7672
Regressed by:
8cf03e0f7672	Bill McCloskey — Bug 919835 - Make session data collection work with multiple processes (r=ttaubert,Yoric)

Comment 4

[Volkmar Kostka]

Is it possible to back-out bug 919835 to test if it is the problem? Beside that the bug is annoying as hell.

Comment 5

[Landis Reed]

this problem is become a serious issue to me.
i have no time to run nightly if i can't restart and continue where i left off before update restarts.
i know that every once in a while there will be issues running Nightly, but Every time i restart is too much, when there is little to no attention being given to this important issue.

my bug report addresses this same issue and has not been looked at, marked dup, rejected, Nothing.
https://bugzilla.mozilla.org/show_bug.cgi?id=934164
or - my post with screenshots at MozillaZine.org
http://forums.mozillazine.org/viewtopic.php?f=23&t=2766287&p=13162997#p13162997

Additionally, I have noticed there is No 'back' history to these tabs (no url) and that if I open a page that is already booked mark, Right-Click on page > choose Bookmark this page the BM dialog acts as if the page is Not bookmarked. This is true, even if I open the page From a BM.. History is shot.

And, I have No sessionstore.json. 
I renamed sessionstore.sqlite to see if FF would 'rebuild' or recreate the sessionstore file. It did, does Not.

Landis.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I was able to reproduce this using the Alice's STR. Then I applied the patch from bug 933587 and the problem seems to have been fixed. Alice, can you confirm?

I'm sorry that this has caused people so much trouble. We do take issues with session restore very seriously. However, it wasn't clear that bug 933587 was actually causing people problems when it was first filed, and I only saw this bug yesterday.

Comment 7

[Alice0775 White]

I cannot reproduce the problem with the STR in comment#2 anymore.

http://hg.mozilla.org/mozilla-central/rev/b4143e04bea1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131104044747

Comment 8

[Landis Reed]

in response to the suggestion at MozillaZine / Builds that it could be an Add-on.
I disabled these Add-ons while troubleshooting sessions not being fully restored (tabs load as 'New Tab' w/o content or url)

Add-on Builder Helper 1.7 false jid0-t3eeRQgGANLCH9c50lPqcTDuNng@jetpack
AddThis 3.5.9 false {3e0e7d2a-070f-4a47-b019-91fe5385ba79}
ChromEdit Plus 2.9.10 false [e-mail]
Custom Buttons 0.0.5.6 false [e-mail]
keyconfig 20110522 false keyconfig@dorando
SQLite Manager 0.8.1 false [e-mail]
Toolbar Button Complete example 0.8.rev20 false jid0-js4YBKRcxaP4PjQJaXuLTBxBjB0@jetpack

After disabeling these, I Quite and Started FF (instead of 'Restart Now')...
I had 3 windows open and all three restored the tabs and content????

I have no idea which Add-on it could be, if in fact a Add-on issue or was the error addressed in today's second update?
FYI... Stylish, Chrome Edit and theme FT Deep Dark 9.2.1 were the last Add-ons i installed 3 or 4 days ago.
Chrome Edit is the only one I'm not using, but was still enabled and the only one of these 3 I disabled before restarting.

Landis.

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Landis, the problem should be fixed in the most recent Firefox nightly. Sorry again for the inconvenience.

Comment 10

[Landis Reed]

I have 3 windows, main (fist in session) has 3 tab groups, second (this) windows 7 tabs and 3rd window 3 tabs, one of which is actual "New Tab". 
I've Quite FF (Nightly) and Started choosing Restore Previous Session.
and I've used my Restart FF button (https://addons.mozilla.org/en-US/firefox/addon/restart-ff-button/) to emulate an 'Update' Restart.

In both cases, All 3 windows restore and All Tabs are restored with Navigation History.

Thanks
Landis.

Comment 11

[Landis Reed]

(In reply to Bill McCloskey (:billm) from comment #9)
> Landis, the problem should be fixed in the most recent Firefox nightly.
> Sorry again for the inconvenience.
> 
> *** This bug has been marked as a duplicate of bug 933587 ***

Thank You. seems to me you're right.. see my comment #10... 

Спесибо, 
Landis.