Closed Bug 934316 Opened 7 years ago Closed 7 years ago

Fix some bad folderpane scrolling perf for feed folders, remove transition code

Categories

(MailNews Core :: Feed Reader, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 28.0

People

(Reporter: alta88, Assigned: alta88)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch fixFeedFolderPerf.patch (obsolete) — Splinter Review
1. Folderpane properties were changed to indicate whether a feed folder had a subscription, running code that for legacy reasons had to check lots of places if a folder was empty.  This is now refactored.
2. Feed folder db sync with the feedUrl property (required to handle folder renames/moves) has been refactored.
3. Bug 271257.
Assignee: nobody → alta88
Attachment #826548 - Flags: review?(mkmelin+mozilla)
Blocks: 271257
Comment on attachment 826548 [details] [diff] [review]
fixFeedFolderPerf.patch

Review of attachment 826548 [details] [diff] [review]:
-----------------------------------------------------------------

Lots of changes. From what i can tell it seems ok. r=mkmelin

::: mailnews/extensions/newsblog/content/feed-subscriptions.js
@@ +1439,5 @@
>        {
>          win.updateStatusItem("progressMeter", 100);
>  
> +        // Add the feed to the databases.
> +        FeedUtils.addFeed(feed); 

trailing whitespace

::: mailnews/local/public/nsINewsBlogFeedDownloader.idl
@@ +17,2 @@
>  
> +  /* A convient method to subscribe to feeds without going through the Subscribe

please make this document comments javadoc/doxygen documentation comments while you're there
/**
 *
 */

::: mailnews/local/src/nsRssIncomingServer.cpp
@@ +192,5 @@
>  }
>  
>  NS_IMETHODIMP nsRssIncomingServer::FolderAdded(nsIMsgFolder *aFolder)
>  {
> +  // Not necessary for new folder adds.

"nothing to do", and maybe point to what it does?
Attachment #826548 - Flags: review?(mkmelin+mozilla) → review+
update for comments.
Attachment #826548 - Attachment is obsolete: true
Attachment #827632 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/e3deddef504b
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
You need to log in before you can comment on or make changes to this bug.