Closed Bug 934842 Opened 8 years ago Closed 8 years ago

Unbreak d3d OMTC reftests by fixing DrawTarget::CopySurface for DataSourceSurfaces

Categories

(Core :: Graphics: Layers, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: nrc, Assigned: nrc)

References

(Depends on 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

No description provided.
Apparently Bas has a patch which covers the SkiaDrawTarget case, so I won't fix that here.
And Core graphics looks like it should work already. So just Cairo and D2D to cover here.
Attachment #827185 - Flags: review?(bas)
Blocks: 899785, 899787
Comment on attachment 827185 [details] [diff] [review]
Fix for Cairo and D2D

Review of attachment 827185 [details] [diff] [review]:
-----------------------------------------------------------------

We'll need to make Skia support this as well ideally.
Attachment #827185 - Flags: review?(bas) → review+
(In reply to Bas Schouten (:bas.schouten) from comment #4)
> Comment on attachment 827185 [details] [diff] [review]
> Fix for Cairo and D2D
> 
> Review of attachment 827185 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> We'll need to make Skia support this as well ideally.

I thought you said you had Skia support on the filters branch? Otherwise I can add it here.
https://hg.mozilla.org/mozilla-central/rev/9c2338877b05
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.