934846 - [LG Fireweb] Phone Accept/ Decline and Lock Popup appear when receiving a call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

User on SUMO reports: 
When phone is asleep and a call is received, while deciding to answer or decline, at the same time the ^ for Camera/ Lock/Unlock is also appearing. You must pick the right one to answer the call. 
User provides video of the issue: https://www.facebook.com/photo.php?v=733888243291420&l=1453044204691946533 
Model: LG-D300F 
Software: D300f10d
OS version: 1.1.0.1 
Firmware revision: LGD300fAT-00-V10d-724-06-SEP-30-2013 
Hardware revision: REV_1.0 
Platform version: 18.1 
Build identifier: 20131005124448 
Update channel: release-lg   

Original SUMO Thread: https://support.mozilla.org/en-US/questions/976398

Needinfo-ing from Naoki.

Comment 1

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

CC'ing Michelle Luna.

Comment 2

[cleber]

There's a n youtube video showing similar behaviour here: http://www.youtube.com/watch?v=yqF9ED3YXo0&sns=em

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Please see the UX issue for this bug, Eric.

Comment 4

[Eric Pang [:epang] UX]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #3)
> Please see the UX issue for this bug, Eric.

Redirecting to Stephany so she can reassign to the correct person. Thanks Stephany! :)

Comment 5

[Stephany Wilkes]

Flagging Rob and Francis to advise on this, and it's important.

Comment 6

[Rob MacDonald [:robmac]]

Tim, is this bug still relevant? It's showing the old lock screen UI.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Rob MacDonald [:robmac] from comment #6)
> Tim, is this bug still relevant? It's showing the old lock screen UI.

It's depend on whether or not we want to push a fix on the version we have already released.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #7)
> (In reply to Rob MacDonald [:robmac] from comment #6)
> > Tim, is this bug still relevant? It's showing the old lock screen UI.
> 
> It's depend on whether or not we want to push a fix on the version we have
> already released.

We aren't going to do that for this bug. The time for hot fixes for 1.1 has really passed - at best, we'll see this solved in 1.2 with the new lockscreen UX. I think we should close this bug out.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

jsmith: we have to fix 1.1 HD.  that's not released.

Comment 10

[Jason Smith [:jsmith]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #9)
> jsmith: we have to fix 1.1 HD.  that's not released.

I don't that warrants blocking on this for 1.1 HD. 1.1 HD should only target WVGA blocking issues & Helix device-specific issues. It's way too late to consider fixing this anyways for 1.1 HD as well, as this would be too risky to fix.

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Did you look at the video?  The person can't answer an incoming phone call.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #11)
> Did you look at the video?  The person can't answer an incoming phone call.

Yes, I did look at it. That problem in that video was the one of the motivators for why the lockscreen UI was rewritten for 1.2.

Comment 13

[Jason Smith [:jsmith]]

Tim - Is a simple fix to this problem here possible? Trying to get a better picture of risk here.

Comment 14

[Preeti Raghunath(:Preeti)]

Wayne,

Please keep an eye out for the bug for 1.1HD.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Jason Smith [:jsmith] from comment #13)
> Tim - Is a simple fix to this problem here possible? Trying to get a better
> picture of risk here.

I don't know. The code lives in dialer call screen, not lock screen, I believe.

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Steve, are you familiar with this?

Comment 17

[Steve Chung [:steveck]]

Sorry I'm not quite familiar with the old version... Maybe yuren will have clear idea about the problem, but I can also take a look when I have free cycle.

Basically the incoming call screen 'should' cover the the system lockscreen, and user should not be able to see/touch the system lockscreen in this case. Hi Andrew, is this issue only reproducable on HD device, and easy to reproduce?

Comment 18

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

I don't have a Fireweb device of my own to reproduce this as I'm reporting for the user on SUMO, but I can't reproduce this on my Keon (I have yet to use my ZTE Open though) both running 1.l.

Comment 19

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

is it reproducible?

call screen should overlap on bottom of lockscreen with a transition, so looks there is no wallpaper or profile photo of contact for call screen.

Comment 20

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

I posted back in the question thread to see if the user can still reproduce - feel free to post in there to get more info from the user.

Comment 21

[Jason Smith [:jsmith]]

(In reply to Yuren Ju [:yurenju] from comment #19)
> is it reproducible?
> 
> call screen should overlap on bottom of lockscreen with a transition, so
> looks there is no wallpaper or profile photo of contact for call screen.

I'll put qawanted to see if we can reproduce this on a Helix device.

Comment 22

[Stephany Wilkes]

Noting that there are many issues with lock screen and that this bug *may* need to be mindful of what's going on in bug #919410.

Comment 23

[cleber]

I didn't understand Yuren's message. 
A workaround I found to keep this bug away is to use the 4-digit lock screen. 
You want me do another video? 
(I don't know if Fireweb is a Helix device... is it?)
IS there something I can do?
thks!

Comment 24

[Matthew Vaughan]

I am not seeing this specific issue occur on the 12/03 1.1 HD or the 12/05 1.3 HD builds. However, I am seeing this issue reproduce on the 12/05 1.2 HD build. 

When there is an incoming call, whether the device is in sleep mode, or the screen is on and displaying the lock screen, the slider for the phone call and the slider for unlocking the device are both present. As soon as the user attempts to use the slider, only the phone call slider will be displayed but will have some graphical glitches when it is used.

Please refer to attached video: 1.2HD_Slider.3gp

- Helix 1.2 Build -
Environmental Variables:
Device: Helix v1.2 COM RIL
BuildID: 20131205004003
Gaia: 0659f16b9790b1cf9eba4d80743fcc774d2ffe3a
Gecko: af2c7ebb5967
Version: 26.0
Firmware Version: Y300-F1V100R001C00B004SP01
RIL Version: 01.02.00.019.102

Comment 25

[Matthew Vaughan]

Attachment: Video of slider during phone call on lockscreen.

Comment 26

[Jason Smith [:jsmith]]

(In reply to Matthew Vaughan from comment #24)
> I am not seeing this specific issue occur on the 12/03 1.1 HD or the 12/05
> 1.3 HD builds. However, I am seeing this issue reproduce on the 12/05 1.2 HD
> build. 
> 
> When there is an incoming call, whether the device is in sleep mode, or the
> screen is on and displaying the lock screen, the slider for the phone call
> and the slider for unlocking the device are both present. As soon as the
> user attempts to use the slider, only the phone call slider will be
> displayed but will have some graphical glitches when it is used.
> 
> Please refer to attached video: 1.2HD_Slider.3gp
> 
> - Helix 1.2 Build -
> Environmental Variables:
> Device: Helix v1.2 COM RIL
> BuildID: 20131205004003
> Gaia: 0659f16b9790b1cf9eba4d80743fcc774d2ffe3a
> Gecko: af2c7ebb5967
> Version: 26.0
> Firmware Version: Y300-F1V100R001C00B004SP01
> RIL Version: 01.02.00.019.102

The 1.2 issue you are seeing sounds like a different bug than this. Can you file a separate bug for this?

Comment 27

[Wayne Chang [:wchang]]

Investigating this with :lchang, the symptom seems to be cosmetic only, i.e. does not affect the ability to answer phone call.


(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #11)
> Did you look at the video?  The person can't answer an incoming phone call.

I looked at the video and it seems that the person hit the homekey instead of sliding the call panel up, and the call panel got retracted (green bar at the top).
But :lchang is investigating further and we'll see what he finds.

Comment 28

[Luke Chang [:lchang] (inactive)]

This issue is caused when we select a photo with incorrect aspect ratio as a wallpaper. In this case, some regions on the "oncall" page might not be covered by the background image so it appears transparent and you'll see the lockscreen below.

After Bug 945098 is landed, it will only happen on the wallpaper chose from camera app directly (and the default wallpaper in settings -- but it's not our problem). I will make a simple patch to fix the style in this bug. However, we still need a solution about how to select a photo from camera app with correct aspect ratio. I'll file a separate bug for that.

Comment 29

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request: 14495

Hi Etienne, 

Would you mind helping review this patch? Thanks a lot!

Comment 30

[Etienne Segonzac (:etienne)]

Comment on attachment 8344530 [details] [review]
Pull Request: 14495

I checked and this bug is indeed fixed for 1.2 and beyond.

For 1.1, this fix looks simple enough, but since I'm unable to test it on a phone I'm uncomfortable reviewing it.

Glad to forward the review to somebody who does.

Cheers !

Comment 31

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8344530 [details] [review]
Pull Request: 14495

Etienne,

Really thanks for your feedback!


Yuren,

Could you please help review this patch? Thanks!

Comment 32

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8344530 [details] [review]
Pull Request: 14495

r=yurenju since Luke help me to reproduce and see the result.

Comment 33

[Luke Chang [:lchang] (inactive)]

Yuren, 

Thanks for your help.


Wayne,

This patch is ready. Do we land it?

Comment 34

[Luke Chang [:lchang] (inactive)]

I've filed a separate bug for the following issue:

Bug 948784 - A wallpaper selected from camera app will be displayed with incorrect aspect ratio

Comment 35

[Wayne Chang [:wchang]]

After checking in with Luke on the root cause and patch here, it should be relatively low risk (CSS change) and could improve user perception here.

HD+ for v1.1HD as it isn't released yet, but recommended for partners taking/making v1.1 update on other devices.


Andrew, is it possible to get the user's wallpaper in the original reporting to verify this what he saw would be fixed with Luke's patch?

Comment 36

[Luke Chang [:lchang] (inactive)]

merged in gaia v1.1.0hd branch:
https://github.com/mozilla-b2g/gaia/commit/2d79d8c461262b4d819fba17a0e8cbc03b36b6b1

Comment 37

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Wayne, the user has not responded to last contact with them on forums..

Comment 38

[Stephany Wilkes]

Removing the ni? flag for UX. We have been testing recent builds and have not seen this issue, and it is fixed. Please re-flag us as necessary.

Comment 39

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

\o/

Looks like the latest OEM build is easy to answer. Thanks for all who made it possible.