934894 - [Flatfish]CardView snapshot are in portrait

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[[e-mail]]

CardView snapshot in tablet should be in landscape

Comment 1

[[e-mail]]

reproduce step:

in tablet:
1. open some apps and swipe up to homescreen
2. use 2 fingers swipe up and see this issue

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: Pr to master

This patch should works on tablet on mobile.
However, there's something wrong on my test env, so I cannot run any unit test locally. I will update test cases and set review asap.

Comment 3

[Francis Lee [:frlee]]

until we have final decision of Flatfish base version (v1.2 or v1.3), change to --- for now.

Comment 4

[Francis Lee [:frlee]]

as we confirmed that Flatfish will use v1.3 and we need to respect current testing cycle, set target milestone to 12/6 since 1.3FC tag is not created yet.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 828090 [details]
Pr to master

Hi Alive,
could you help to review this patch?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 828090 [details]
Pr to master

Thanks for fixing my bug.

BTW, I'm writing unit test for window.js now. So just land it first.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Alive,
merge into master,
https://github.com/mozilla-b2g/gaia/commit/278842dfeb86c6e0634a7ff3dc76e479bf72ad99