935177 - [Messages][Drafts] Update "discard message" confirmation prompt to options menu/dialog; add "save draft" no-op

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Rick Waldron [:rwaldron]]

Per page 29 of FFOS_MessageApp_V1.3_20131031_V6.0.pdf, the "discard message" confirmation prompt is being evolved from a simple "confirm" to a multi-option dialog prompt.

This bug will:

- Replace the Confirm prompt with an OptionsMenu prompt
  - Option: "Save as Draft" -> This will be a no-op
  - Option: "Discard" -> Handles the previous "discarding" behaviour
- Update existing tests for that operation

Comment 1

[Rick Waldron [:rwaldron]]

Attachment: 935177.png

Comment 2

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/13117

Green https://travis-ci.org/mozilla-b2g/gaia/builds/13658571

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

1.3+ for blocking 1.3 committed user story

Comment 4

[Adam Hyland [:protonk]]

Did you mean to attach https://github.com/mozilla-b2g/gaia/pull/13483 

Instead I see a PR from kevin grandon for another bug.
(In reply to Rick Waldron [:rwaldron] from comment #2)
> Created attachment 828964 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/13117
> 
> Green https://travis-ci.org/mozilla-b2g/gaia/builds/13658571

Comment 5

[Rick Waldron [:rwaldron]]

(In reply to Adam Hyland [:protonk] from comment #4)
> Did you mean to attach https://github.com/mozilla-b2g/gaia/pull/13483 
> 
> Instead I see a PR from kevin grandon for another bug.
> (In reply to Rick Waldron [:rwaldron] from comment #2)
> > Created attachment 828964 [details] [review]
> > https://github.com/mozilla-b2g/gaia/pull/13117
> > 
> > Green https://travis-ci.org/mozilla-b2g/gaia/builds/13658571


whoops. That was a copy/paste blunder!

Comment 6

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/13483

Comment 7

[Adam Hyland [:protonk]]

Comment on attachment 829805 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13483

Looks good to me (comments on the PR). Is there a mechanism for letting the localization team know we just added 2 more keys?

Comment 8

[Rick Waldron [:rwaldron]]

(In reply to Adam Hyland [:protonk] from comment #7)
> Comment on attachment 829805 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/13483
> 
> Looks good to me (comments on the PR). Is there a mechanism for letting the
> localization team know we just added 2 more keys?


^^^

Comment 9

[Axel Hecht [:Pike]]

Landing tells us, basically. As this is not for 1.2, there's no extra concern.

If you're concerned about the quality of the strings themselves, you should get feedback from a native speaker in UX, or someone like Matej.

Comment 10

[Rick Waldron [:rwaldron]]

(In reply to Axel Hecht [:Pike] from comment #9)
> Landing tells us, basically. As this is not for 1.2, there's no extra
> concern.
> 
> If you're concerned about the quality of the strings themselves, you should
> get feedback from a native speaker in UX, or someone like Matej.

Thanks!

Comment 11

[Francesco Lodolo [:flod]]

Is the discard-sms still used somewhere? Because I only see the dropped line using that ID.

Comment 12

[Rick Waldron [:rwaldron]]

PR updated

Comment 13

[Julien Wajsberg [:julienw]]

Comment on attachment 829805 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13483

lgtm but I would like that it doesn't land on master.

Could we have a "v1.3-draft" branch somewhere, maybe in bocoup's repository, where we can land r+ commits?

We could land on master as soon as we have something consistent.

Of course this means you'll have some rebase work to do, but I think this is a bad idea to land only part of features.

Comment 14

[Rick Waldron [:rwaldron]]

(In reply to Julien Wajsberg [:julienw] from comment #13)
> Comment on attachment 829805 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/13483
> 
> lgtm but I would like that it doesn't land on master.
> 
> Could we have a "v1.3-draft" branch somewhere, maybe in bocoup's repository,
> where we can land r+ commits?
> 
> We could land on master as soon as we have something consistent.
> 
> Of course this means you'll have some rebase work to do, but I think this is
> a bad idea to land only part of features.

There is no difference in a bocoup repo or in my own, so let's just keep the PR r+'ed and I will maintain the patch until it's ready to land.

Comment 15

[Evelyn Eastmond [:evhan55]]

Comment on attachment 829805 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13483

Sorry this is late, FWIW looks good to me so far.

Comment 16

[Julien Wajsberg [:julienw]]

> There is no difference in a bocoup repo or in my own, so let's just keep the PR r+'ed and I 
> will maintain the patch until it's ready to land.

Except it's more difficult for evelyn and adam to work :) It would be easier to have a common branch for all this work. (and easier for reviewer to test patches as well)

Comment 17

[Evelyn Eastmond [:evhan55]]

FYI, my branch 936641 will likely be a dupe/addition onto this one:

https://github.com/evhan55/gaia/compare/936641

Comment 18

[Julien Wajsberg [:julienw]]

Can't we just have a "draft" branch somewhere, where all uncompatible draft stuff will land ?

Comment 19

[Evelyn Eastmond [:evhan55]]

(In reply to Julien Wajsberg [:julienw] from comment #18)
> Can't we just have a "draft" branch somewhere, where all uncompatible draft
> stuff will land ?

I'll check with Rick and Adam and try to resolve this, thanks!

Comment 20

[Rick Waldron [:rwaldron]]

Ok, so we're back to an "update" instead of a removal.

Comment 21

[Rick Waldron [:rwaldron]]

There are changes in #929919 that will directly affect the WIP branch


(mostly a note for myself)

Comment 22

[Rick Waldron [:rwaldron]]

(In reply to Julien Wajsberg [:julienw] from comment #13)
> Comment on attachment 829805 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/13483
> 
> lgtm but I would like that it doesn't land on master.
> 
> Could we have a "v1.3-draft" branch somewhere, maybe in bocoup's repository,
> where we can land r+ commits?
> 
> We could land on master as soon as we have something consistent.
> 
> Of course this means you'll have some rebase work to do, but I think this is
> a bad idea to land only part of features.


Feature branch is here: https://github.com/rwaldron/gaia/tree/v1.3-drafts

Comment 23

[Rick Waldron [:rwaldron]]

https://github.com/mozilla-b2g/gaia/commit/c936b357b07cf6a031a15005ba003ddb8c251fac