929919 - [Messaging] getThreads optimization

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Update the logic in 'getThreads' method due to now it's not well-optimized.

Comment 1

[Borja Salguero [:borjasalguero]]

This is needed because due to the current logic of 'getThreads', we are requesting the entire list of threads *every time* we are sending a new message to a new recipient. This is definitely a non-optimized implementation, and *blocks* the APP when the list of threads is large.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

blocking a committed 1.3 user story. 1.3+

Comment 3

[Julien Wajsberg [:julienw]]

Sorry, this is blocking nothing here. This is like this since 1.0. Please don't abuse the flags and dependencies.

That said, I'd be very happy with landing this for 1.3. It's just that this won't hold the release.

Comment 4

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

Comment 5

[Borja Salguero [:borjasalguero]]

This is part of the work needed in getThreads, due to when the amount of threads is large, forwarding a message or sending a new one could be stucked for seconds in the composer due to this bug. Waiting Julien's review, and one this will be in master, I'll request 1.3? Flag.

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 828048 [details]
Pull request

Comments on github

please do smaller patches in the future. Big patches makes it harder to focus and therefore to review and as a result it takes too much of my time.

Thanks!

Comment 7

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

This is the patch solving multiple request to getThreads, improving the performance!

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8336005 [details] [diff] [review]
Pull request

review is finished!

Overall a welcome addition but I think this can be even better!

Please add a new commit for the follow-ups to your existing commit so that the next review is easy ;)

Comment 9

[Borja Salguero [:borjasalguero]]

Comment on attachment 8336005 [details] [diff] [review]
Pull request

Code updated! r?

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 8336005 [details] [diff] [review]
Pull request

r=me

thanks, this is a very helpful addition!

Comment 11

[Julien Wajsberg [:julienw]]

Bug 943778 is a follow-up for creating a more OO approach on threads.

Comment 12

[Borja Salguero [:borjasalguero]]

https://github.com/borjasalguero/gaia/commit/8115e89f4bd5b1f3cb68545f48aa20bb2d7dbe07
https://github.com/mozilla-b2g/gaia/commit/15494b980a88ae7dfb8ba48164ea01ec3b35b86f
R+. Merged!