935178 - Story - Support broadcast message for switching between Metro and Desktop

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect, P1)

Description

[Brian R. Bondy [:bbondy]]

We should add support for auto-switch to Metro and auto-switch to Desktop browsers.

To do this we should follow Intels' guidelines here:
http://software.intel.com/en-us/articles/detecting-slateclamshell-mode-screen-orientation-in-convertible-pc

Basically we'll need to add to our WinRT and Win32 widget layer, message handling for WM_SETTINGS with an lPram of “ConvertibleSlateMode”.

To detect the mode we'd use GetSystemMetrics:
BOOL bSlateMode = (GetSystemMetrics(SM_CONVERTIBLESLATEMODE) == 0);

We'd use the code from bug 924911 and bug 924914 to do a relaunch in response to these messages if a mode switch is detected and the wrong browser is running.

p=3

Note for Marco: I'm going to delay subtracting this from the contingency fund until we get hardware that supports this.  That way we can verify a good experience.

Comment 1

[Brian R. Bondy [:bbondy]]

Removed 3 points from the contingency bug for this.

Comment 2

[Brian R. Bondy [:bbondy]]

Dell device from Intel that supports this just arrived this morning. Going to aim to get this work in during this 2-week iteration sprint.

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: rev1

A bit of background, mfinkle, krudnitski, and I had a meeting with Intel about supporting this functionality. They sent myself and Juan an XPS 12 to develop and test the functionality. 

Basically when you transform the laptop into a tablet, and you have the desktop browser open, it will close that and open the Metro browser.  Likewise, when you are in tablet mode, and you transform to a laptop, if you have the Metro browser open it will close and open the Desktop browser.

See this link for more information:
http://software.intel.com/en-us/articles/detecting-slateclamshell-mode-screen-orientation-in-convertible-pc

I tried it out and it feels awesome to me :)

Comment 4

[Jim Mathies [:jimm]]

We should tie this to a pref so people can turn it off.

Comment 5

[Jim Mathies [:jimm]]

Do these tablets automatically switch between the touch interface and desktop? I'm curious what else happens on the device when you switch modes.

Comment 6

[Brian R. Bondy [:bbondy]]

Just to keep this bug sync'ed up to IRC:
[13:27:57] <bbondy> jimm: ping, check out this video http://dot.kde.org/2013/09/11/krita-demonstrated-
[13:28:13] <bbondy> witch-> switch
[13:29:53] <jimm> bbondy: thx
[13:30:19] <bbondy> that video shows a paint program doing the same thing
[13:30:25] <bbondy> they generally switch via file activation
[13:30:30] <bbondy> we do via url activation

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8333594 [details] [diff] [review]
rev1

bbondy's going to add a pref in a follow up.

Comment 8

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/projects/oak/rev/95f653bf41d9

Bug 935099 will track the landing on m-c.
When it lands on m-c a new comment will be added here as well with the m-c changeset.
This is being done so we can still use scrumbugs efficiently. 
See bug 935099 for further details.

Comment 9

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/fx-team/rev/594ae98c4fdd

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/594ae98c4fdd