Closed
Bug 935241
Opened 11 years ago
Closed 7 years ago
Return early in _fillTrailingGap if we're not overflowing to avoid unnecessary work
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
DUPLICATE
of bug 1364661
People
(Reporter: MattN, Unassigned)
References
Details
(Keywords: perf, Whiteboard: [Australis:P-][Australis:M-])
(Quoting Matthew N. [:MattN] from bug 899867 comment #7) > Created attachment 790091 [details] [diff] [review] > Part 2 - v.1 - Early return in _fillTrailingGap if we're not overflowing > > If we don't flush layout from getting the tabstrip's width (e.g. part 1 / > attachment 783498 [details] [diff] [review]), then _fillTrailingGap ends up > causing us to flush. > > It seems like _fillTrailingGap doesn't need to do anything if we aren't > overflowing since I believe that means we aren't scrolling either. I haven't > tested this yet so it's possible that the overflow attribute is not set in > time when narrowing the window. i.e. I need to check the ordering of the > resize and overflow events. I haven't had time to investigate if this has an impact on our benchmarks after changes like bug 905695. If someone wants to steal this from me, feel free. This fix isn't Australis-specific.
Reporter | ||
Updated•10 years ago
|
Assignee: MattN+bmo → nobody
Status: ASSIGNED → NEW
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•