Closed
Bug 935244
Opened 11 years ago
Closed 11 years ago
[robocop] Avoid over-swiping about:home tabs in AboutHomeTest.swipeAboutHome
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 947550
People
(Reporter: Margaret, Unassigned)
References
Details
Attachments
(1 obsolete file)
This seems to be a problem on phones when running tests locally.
Reporter | ||
Comment 1•11 years ago
|
||
Puhsed to try:
https://tbpl.mozilla.org/?tree=Try&rev=01bf60395f5d
Attachment #827645 -
Flags: review?(liuche)
Comment 2•11 years ago
|
||
Comment on attachment 827645 [details] [diff] [review]
patch
Review of attachment 827645 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, maybe you can add a comment regarding why we're choosing width/2 as the swipe value (instead of the full width), optionally wrt to phones and tablets.
Attachment #827645 -
Flags: review?(liuche) → review+
Reporter | ||
Comment 3•11 years ago
|
||
Unfortunately, it looks like this is causing problems on the pandas :(
I'll try debugging this on a tablet, since I was only testing locally on a phone.
Reporter | ||
Comment 4•11 years ago
|
||
I'm not actively working on this, so unassigning. I think we should revisit this after bug 910859 lands, in case the new AboutHomeComponent helps fix this issue.
Assignee: margaret.leibovic → nobody
Component: Awesomescreen → Testing
Reporter | ||
Updated•11 years ago
|
Attachment #827645 -
Attachment is obsolete: true
Depends on: 910859
via IRC:
<mcomella> margaret: What's an overswipe (bug 935244)?
<margaret> mcomella: we would end up moving 2 pages with one swipe gesture
This should be fixed with bug 947550.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
(In reply to Michael Comella (:mcomella) from comment #6)
> This should be fixed with bug 947550.
For UITest. See bug 1023637 for BaseTest.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•