935249 - [Download Manager] New icon for button "Downloads" in settings list

Status: RESOLVED DUPLICATE of bug 935088

(Firefox OS Graveyard :: Gaia, defect)

Description

[Cristian Rodriguez (:crdlc)]

We need an tiny icon for "Downloads" item in settings app like the rest of items (Sound, Display, etc..)

Comment 1

[Cristian Rodriguez (:crdlc)]

Francis, could you assign this bug to the correct person?

Comment 2

[Francis Djabri [:djabber]]

Eric, assuming that you're right person for this? Please check out bug 926955 for more info.

Comment 3

[Cristian Rodriguez (:crdlc)]

We need icons for notifications: failed, finished, stopped, etc. Thanks a lot

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

I would add as well, icons for the statuses and actions within the contact list ;), but I guess we will reuse.

Comment 5

[Eric Pang [:epang] UX]

Attachment: icon_settings_download.png

I've attached the download icon for settings.  Christian, Peter should be able to help with the other icons listed - Peter will you be working on the new icons for the download manager?

Comment 6

[Cristian Rodriguez (:crdlc)]

Hi, thanks a lot Eric, it is the first time that we work on Settings app but the images in the list are defined as sprite thought. Kaze, could you confirm it? or could we use it instead of the sprite for the new download item?

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/images/icons_sprite.gif

Comment 7

[Eric Pang [:epang] UX]

(In reply to Cristian Rodriguez (:crdlc) from comment #6)
> Hi, thanks a lot Eric, it is the first time that we work on Settings app but
> the images in the list are defined as sprite thought. Kaze, could you
> confirm it? or could we use it instead of the sprite for the new download
> item?
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/images/
> icons_sprite.gif

Hi Christian, yes we have used sprites in the past.  But a while ago I was told that I no longer needed to export them into a sprite.  So i'm a bit confused :).  Let me know if it's needed and I can add it to the sprite.  Thanks!

Comment 8

[Eric Pang [:epang] UX]

see comment 3, Peter let me know to redirect to you. Thanks!

Comment 9

[Fabien Cazenave [:kaze]]

(In reply to Cristian Rodriguez (:crdlc) from comment #6)
> Hi, thanks a lot Eric, it is the first time that we work on Settings app but
> the images in the list are defined as sprite thought. Kaze, could you
> confirm it? or could we use it instead of the sprite for the new download
> item?

Let’s keep using sprites, please.

(In reply to Eric Pang [:epang] from comment #7)
> Hi Christian, yes we have used sprites in the past.  But a while ago I was
> told that I no longer needed to export them into a sprite.  So i'm a bit
> confused :)

So am I. ^^
If there’s been a platform or system improvement that makes CSS sprites useless, please let me know.

Comment 10

[Amy Lee [:amylee] UX]

Attachment: Notifications_Tray_Download_Manager_Icons.zip

Hi, 
Hi Cristian,

Here are the download manager icons for the notifications tray. I've provided @1 and @1.5 scaled icons for Download Failed and Download Completed (based on Francis' wireframes). For Downloading in progress please use the default blue spinner loader. Please let me know if you need anything else.

Comment 11

[Cristian Rodriguez (:crdlc)]

Hi Amy,

   I need another icon when the download has been started. If you see the wireframes, the toaster is displayed during a bit seconds saying: "Download started". We need another one or could we use the download complete icon?

Thanks

Comment 12

[Amy Lee [:amylee] UX]

Hi Cristian, 

Which page in the wireframe are you referring to? 
https://bug926955.bugzilla.mozilla.org/attachment.cgi?id=8335680

I can't find a screen where it has a "download started" message/icon. Once the download has started, there should only be the progress bar.

(In reply to Cristian Rodriguez (:crdlc) from comment #11)
> Hi Amy,
> 
>    I need another icon when the download has been started. If you see the
> wireframes, the toaster is displayed during a bit seconds saying: "Download
> started". We need another one or could we use the download complete icon?
> 
> Thanks

Comment 13

[Cristian Rodriguez (:crdlc)]

Hi, please go to pages 13 or 15, you can see the toaster saying download is started, thanks

Comment 14

[Amy Lee [:amylee] UX]

Hi Cristian, 

Is it possible to use the download complete icon but have the opacity animate from 50% - 100% back and forth like it's pulsing? If not, then please use the download complete icon @100 opacity. 

Thanks!

Comment 15

[Borja Salguero [:borjasalguero]]

Hi Eric,
As :kaze & :crdlc explained previously, we are using an sprite for *all* icons in Settings App list. As  you can see is quite updated (you will see, for example, NFC), so we need the Sprite updated following the same pattern as before. Could you help us here? We are blocked here and we need to move forward. Thanks!

Comment 16

[Eric Pang [:epang] UX]

(In reply to Borja Salguero [:borjasalguero] from comment #15)
> Hi Eric,
> As :kaze & :crdlc explained previously, we are using an sprite for *all*
> icons in Settings App list. As  you can see is quite updated (you will see,
> for example, NFC), so we need the Sprite updated following the same pattern
> as before. Could you help us here? We are blocked here and we need to move
> forward. Thanks!

Hi Borja,
Amy will be able to help you out with this :).  Amy, can you help Borja with this?

Thanks!

Comment 17

[Amy Lee [:amylee] UX]

Hi Borja, 

Since the sprite sheet is full I will need to add another row to the bottom of the sprite sheet. Is this okay?

(In reply to Eric Pang [:epang] from comment #16)
> (In reply to Borja Salguero [:borjasalguero] from comment #15)
> > Hi Eric,
> > As :kaze & :crdlc explained previously, we are using an sprite for *all*
> > icons in Settings App list. As  you can see is quite updated (you will see,
> > for example, NFC), so we need the Sprite updated following the same pattern
> > as before. Could you help us here? We are blocked here and we need to move
> > forward. Thanks!
> 
> Hi Borja,
> Amy will be able to help you out with this :).  Amy, can you help Borja with
> this?
> 
> Thanks!

Comment 18

[Borja Salguero [:borjasalguero]]

(In reply to Amy from comment #17)

> Since the sprite sheet is full I will need to add another row to the bottom
> of the sprite sheet. Is this okay?

Yep! It seems that every icon is using 30x30 [1], so adding one row taking into account this will work! :) Please add me a needinfo? once you upload the sprite and I'll check if is working! Thanks! Gracias!


[1]https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/icons.css#L49

Comment 19

[Amy Lee [:amylee] UX]

Attachment: Settings_Sprites_Download_Icon.zip

Hi Borja, 

Attached are the updated sprites with the download icon. Let me know if you need anything else.

Comment 20

[Borja Salguero [:borjasalguero]]

Hi Amy,
Checking all resources in Settings APP, we would need as well x2 version (no we have x1 and x1.5). Could you add this sprite to the zip? Thanks!

Comment 21

[Amy Lee [:amylee] UX]

(In reply to Borja Salguero [:borjasalguero] from comment #20)
> Hi Amy,
> Checking all resources in Settings APP, we would need as well x2 version (no
> we have x1 and x1.5). Could you add this sprite to the zip? Thanks!

Hi Borja, 

We are not supporting any @2 graphics anymore. Thanks

Comment 22

[Borja Salguero [:borjasalguero]]

Icon is included in the work done (and r+) in bug #935088. Thanks Amy for the sprite! It's working perfectly ;)