935352 - [Flatfish] Dock panel is fixed still until 7th~8th app icons landed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[RaymondSu]

Attachment: Moved app icons to docking-1.jpg

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36

Steps to reproduce:

1. Stay in Launcher screen 
2. Add in and Move out App icon to the dock panel
3. Try to swipe dock panel



Actual results:

1. Alignment of app icon from left side (not in the middle)
2. The first app icon is pushed out to left (or disappear?) while add 5th app icon.
3. The first app and second icon are pushed out to left (or disappear?) while add 6th app icon.
4. Can not swipe dock (during 1~6th app icons) until 7th app icon added onto the dock
5. Maximum of app icons on dock panel are eight icons


Expected results:

Not sure what's the right UI behavior.
Personally thinking:
1. Make sure the location of dock panel icons keeping aligned with the middle
2. Make sure the maximum number of app icons on the dock panel and the proper way to swipe if bigger than the capacity of single dock panel

Comment 1

[RaymondSu]

Attachment: Moved app icons to docking-2.jpg

Comment 2

[RaymondSu]

Attachment: Moved app icons to docking-3.jpg

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

I think this is related to 
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/dock.js#L191
we use the first icon's width, however, the width include padding's size a below
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/style/dock.css#L94
So, we get the wrong value to calculate the position.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Fred,
I think this patch should be able to fix this bug, since our current gaia can return us correct windowWidth. Please let me know if you have any concern, then I'll ask Cristian to review it again.
Thanks.

Comment 5

[[e-mail]]

Comment on attachment 828123 [details]
PR to master

looks good to me, thanks!

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 828123 [details]
PR to master

Hi Cristian,
since tablet can get correct windowWidth now, I remove these css workaround to fix this bug. Please kindly check.

Thanks.

Comment 7

[Cristian Rodriguez (:crdlc)]

Comment on attachment 828123 [details]
PR to master

Cool, thanks

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks, Cristian and Fred,
merged into master,
https://github.com/mozilla-b2g/gaia/commit/6a194fce88c2e687ee53e23fb7422db31a7ec05d