935372 - browser_overflowScroll.js fails with non-default DPI on Windows

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

I reliably see failures in browser_overflowScroll.js due to sub-pixel comparisons failing.  I *think* this is caused by my machine having DPI set to 125%.  Adding dao and enn as they've touched this file and may have ideas.


 0:48.28 TEST-START | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js
 0:48.37 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Selecting the first tab scrolls it into view (56.399993896484375 <= 56.399993896484375)
 0:48.37 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Scrolled one tab to the right with a single click - Got 1070, expected 1070.199951171875
 0:48.37 Stack trace:
 0:48.37     JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 641
 0:48.37     JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js :: isRight :: line 11
 0:48.37     JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js :: runOverflowTests :: line 55
 0:48.37     native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
 0:48.37 
 0:48.37 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Selecting the last tab scrolls it into view (1071.5999755859375 <= 1070.199951171875)
 0:48.37 Stack trace:
 0:48.37     JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js :: runOverflowTests :: line 59
 0:48.37     native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
 0:48.37 
 0:48.37 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Scrolled one tab to the left with a single click
 0:48.37 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Scrolled one page of tabs with a double click
 0:48.37 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Scrolled to the start with a triple click (56.399993896484375 <= 56.399993896484375)
 0:48.38 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Remained at the start with the mouse wheel
 0:48.38 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Scrolled one tab to the right with the mouse wheel - Got 1070, expected 1070.199951171875
 0:48.38 Stack trace:
 0:48.38     JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 641
 0:48.38     JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js :: isRight :: line 11
 0:48.38     JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js :: runOverflowTests :: line 80
 0:48.38     native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 1

[Dão Gottwald [:dao]]

"Got 1070, expected 1070.199951171875" looks like it just needs rounding. It's not immediately clear to me what's going on with "1071.5999755859375 <= 1070.199951171875".

Comment 2

[Dão Gottwald [:dao]]

Bug 1913322 may have fixed this.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 935372 - Enable browser_overflowScroll.js on Win11. r=#tabbrowser

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b574ac8d2a27
Enable browser_overflowScroll.js on Win11. r=tabbrowser-reviewers,dwalker

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b574ac8d2a27