1913322 - Remove overflow / underflow event usage from arrowscrollbox / tabs.js.

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao

For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
overflow-clip-box-block: content-box in the only place that we make
the scrollbox grow.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1658290c1b95
Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers

Comment 3

[Iulian Moraru]

Backed out for causing overflow related failures.

• Push with failures

• Failure log for mochitest-chrome failures

• Failure log for bc failures

• Backout link

LATER EDIT: it seems that this has caused more bc failures, like:

• bc failures on browser_tabclose_grow.js
• bc failures on browser_tabstrip_overflow_underflow.js
• bc failures on browser_newtabButton.js
• bc failures on browser_saveLastPiPLoc.js
• bc failures on browser_multiselect_tabs_mute_unmute.js
• bc failures on browser_usercontextid_tabdrop.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fb2cecebdd8
Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers

Comment 5

[Cristian Tuns]

Backed out for causing multiple failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/contextualidentity/test/browser/browser_newtabButton.js | new tab button should not be hidden -

Failure log 2: https://treeherder.mozilla.org/logviewer?job_id=471114762&repo=autoland
Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_menulist_position.xhtml | Labels vertically aligned for 5 : 147.5 vs. 131
TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_menulist_position.xhtml | Labels vertically aligned for 6 : 147.5 vs. 131

Failure log 3: https://treeherder.mozilla.org/logviewer?job_id=471129263&repo=autoland
Failure line 3: TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_saveLastPiPLoc.js | waiting for vsync to be disabled - timed out after 50 tries. - false == true -

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d4782d16aac
Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9d4782d16aac