935692 - Crash in [@ ReportErrorRunnable::ReportError ]

Status: VERIFIED FIXED

(Core :: DOM: Workers, defect)

Description

[[:Aleksej]]

Attachment: test1.xpi testcase from bug 933424, with better compatibility indicated

Steps to reproduce:
1. Install the extension, restart.
2. Open test1:test

Firefox crashes.

Comment 1

[[:Aleksej]]

bp-31c35202-2649-483c-80aa-550bd2131106
bp-ac6e1447-7772-46f6-a52e-c69ef2131106
bp-5b3a5885-5b99-4352-af47-fc8fe2131106

WFM: 2013-11-05-03-02-06-mozilla-central-firefox-28.0a1.en-US.linux-x86_64 770de5942471
Bug: 2013-11-06-03-02-00-mozilla-central-firefox-28.0a1.en-US.linux-x86_64 9ba3faa35c96

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=770de5942471&tochange=9ba3faa35c96

Comment 2

[u279076]

(In reply to Aleksej [:Aleksej] from comment #1)
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=770de5942471&tochange=9ba3faa35c96

Can you try to narrow this down further using tinderbox builds?

Comment 3

[[:Aleksej]]

WFM (05 build 4) 20131105122019 2ada3a06d5e7 https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1383682819/firefox-28.0a1.en-US.linux-x86_64.tar.bz2
Bug (05 build 5) 20131105122923 8b89e6626298 https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1383683363/firefox-28.0a1.en-US.linux-x86_64.tar.bz2

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2ada3a06d5e7&tochange=8b89e6626298

Comment 4

[u279076]

(In reply to Aleksej [:Aleksej] from comment #3)
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2ada3a06d5e7&tochange=8b89e6626298

I'm seeing several worker related changes here. Kyle do you know what might have caused this?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Probably one of my changes where I rewrote a good chunk of worker code.

Comment 7

[Matthew N. [:MattN]]

This affects Windows and OS X too.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

What the old code was doing doesn't really make any sense, so lets not even try to do it.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79340a11b93c

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/682c905ee68d

backed out because of warnings as errors crap.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Relanded

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4fca3fba59

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d4fca3fba59

Comment 13

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8343450 [details] [diff] [review]
Patch

This is a regression introduced in 28.  Let's take the fix on Aurora.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 928312
User impact if declined: Possible crashes when using hte web worker API
Testing completed (on m-c, etc.): On m-c, simple patch.
Risk to taking this patch (and alternatives if risky): Low risk.
String or IDL/UUID changes made by this patch: None.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10450b2660bc

Comment 15

[u279076]

Aleksej, does this reproduce for you anymore?

Comment 16

[Paul Silaghi, QA [:pauly]]

Reproduced on nightly 2013-11-07.
Verified fixed 29.0a1 (2013-12-18), win 7 x64

Comment 17

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (X11; Linux i686; rv:28.0) Gecko/20100101 Firefox/28.0

Reproduced the initial issue on nightly 2013-11-07, verified as fixed on latest Aurora 28.0a2 (buildID: 20140103004002).

Comment 18

[[:Aleksej]]

Verified by the people above. Thanks.