Closed Bug 935833 Opened 6 years ago Closed 6 years ago

[Flatfish] [System] Make sleep menu not fill full screen

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(3 files, 2 obsolete files)

let shutdown menu (menu appeared after long press power button) use modal dialog instead
Blocks: flatfish, 935816
Summary: [Flatfish] [System] Make shutdown menu not fill full screen → [Flatfish] [System] Make sleep menu not fill full screen
Assignee: nobody → gasolin
Attached image sleep menu UI spec
Attached image WIP: sleep menu (obsolete) —
WIP, main layout ready, need adjust Header and add tablet specific icons
Attached image near complete screenshot (obsolete) —
Fang, according to UI spec, the main container is 39rem, with 4 column items which are 4.7rem height and 3rem top margin, they occupied

5*3(5 margin include 1 bottom margin) + 4.7*4 (4 items)
= 33.8rem

which means the title could only use 39-33.8 = 5.2rem

Attached file is the screenshot with this setup. Please help check if its a proper result, or kindly provide new numbers.
Flags: needinfo?(fshih)
per offline discussion, the first list item has 3rem margin and others has 2.4rem margin.

Add the icon for tablet menu, ready for review
Attachment #832164 - Attachment is obsolete: true
Attachment #832208 - Attachment is obsolete: true
Attachment #832905 - Flags: review?(alive)
Flags: needinfo?(fshih)
Attached image tablet screenshot
Comment on attachment 832905 [details] [review]
pull request redirect to github

r+ if you change the rule to data-value
Attachment #832905 - Flags: review?(alive) → review+
Update to use [data-value="xxx"] syntax in style,

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/9e3012065962019fa86448daa83b60a9072e9093

thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.