Closed
Bug 935835
Opened 11 years ago
Closed 11 years ago
[HW test] [polish] highlight the selected tab
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: tjao)
References
Details
Attachments
(1 file)
the current selected tab is not easy to identify expect: the tab stay in other color after clicked
|
Reporter | |
Updated•11 years ago
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #829146 -
Flags: review?(flin)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 829146 [details] [review] https://github.com/mozilla-b2g/gaia/pull/13507 see comment in github
Attachment #829146 -
Flags: review?(flin) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
I found the tab not highlighted after clicking "back" button. So I add a new variable to record the selected tab.
|
|
Assignee | |
Updated•11 years ago
|
Attachment #829146 -
Flags: review+ → review?(flin)
|
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 829146 [details] [review] https://github.com/mozilla-b2g/gaia/pull/13507 I'm ok with the origin one, but its nice to have more context. Thanks!
Attachment #829146 -
Flags: review?(flin) → review+
|
|
Reporter | |
Comment 5•11 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/6794bfacd1dcccb26dbc544fa00407f864766ec1 thanks
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Assignee: nobody → tjao
You need to log in
before you can comment on or make changes to this bug.
Description
•