[HW test] [polish] highlight the selected tab

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gasolin, Assigned: tjao)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

the current selected tab is not easy to identify

expect:

the tab stay in other color after clicked
Blocks: eng-mode
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Attachment #829146 - Flags: review?(flin)
Comment on attachment 829146 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13507

see comment in github
Attachment #829146 - Flags: review?(flin) → review+
I found the tab not highlighted after clicking "back" button. So I add a new variable to record the selected tab.
Attachment #829146 - Flags: review+ → review?(flin)
Comment on attachment 829146 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13507

I'm ok with the origin one, but its nice to have more context. Thanks!
Attachment #829146 - Flags: review?(flin) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/6794bfacd1dcccb26dbc544fa00407f864766ec1

thanks
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → tjao
You need to log in before you can comment on or make changes to this bug.