935845 - E.me search box does not start search with IME composed strings (with composition events)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #933592 +++

STR:

0. enable Pinyin IME with "GAIA_KEYBOARD_LAYOUTS=en,zh-Hans-Pinyin make reset-gaia" to enable pinyin IME after Bug 884752 is landed, and in the Settings -> keyboard
1. start typing something, like "taibei", you will see "tai bei" with an underline.
2. confirm the character by select "台北"

Expected: 

1a. e.me should start searching apps related to 台北 in step 2, or,
1b. e.me should start searching apps as soon as user starts typing in step 1 (but the server would have to search against the unconfirmed spellings like "tai bei" above)

Actual:

1. nothing

Note:

1. if you press the suggestion "市", search will start. That's because suggestion string comes with key events. that will be fixed soon.
2. the underlined string is sent with compostionstart and compositionupdate events. If you want to do (1b), you could listen to these two events.
3. if you only want to do (1a), you could listen to compositionend event.
4. for the sake of simplicity, instead of listens to all key* and composition* events, listen to |input| event that accompanies all of the events.

Blocking:

If we are shipping a device with Pinyin *and* E.me enabled, this bug should block.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: WIP

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I should probably not fix this good first bug, but I will if it annoys me too much :P

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #0)
> Blocking:
> 
> If we are shipping a device with Pinyin *and* E.me enabled, this bug should
> block.

We are not blocking on this bug for koi+. But it would be nice if this is targeted this at v1.3.

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

I've created a patch BUT since 'compositionupdate' triggers before the 'input.value' gets updated (similar to 'onkeydown'), the server is sent the previous value :/
Any way around this? Who can I contact about this?

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Ran Ben Aharon (Everything.me) from comment #4)
> I've created a patch BUT since 'compositionupdate' triggers before the
> 'input.value' gets updated (similar to 'onkeydown'), the server is sent the
> previous value :/
> Any way around this? Who can I contact about this?

Ran, the timing of compositionupdate and compositionend events is by design. You should listen to 'input' event that immediately follows (if you would like to send a query after every compositionupdate).

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Comin' right up :)

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 830786 [details]
Patch - redirect to github PR

With Evyatar's review is enough for me here although it looks good to me ;)

Comment 9

[Evyatar 'Tron' Amitay (everything.me)]

Comment on attachment 830786 [details]
Patch - redirect to github PR

Wasn't aware of "input" event! r+.

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 830786 [details]
Patch - redirect to github PR

Tim, I'd like you to experience it before I merge it.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 830786 [details]
Patch - redirect to github PR

Yeah, it works, thanks!

Comment 12

[Ran Ben Aharon [:ranbena] EverythingMe]

Landed on master
https://github.com/mozilla-b2g/gaia/commit/02e8187d5ecbc05d6769161a95606437e2a7338f