942845 - Results refresh twice after pressing enter on the keyboard

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Zac C (:zac)]

STR 
1. Tap in e.me search panel
2. Type in 'twitter'
3. Tap enter key, observe the results load
4. Wait 2-3 seconds
5. results will clear and re-load again


Device Hamachi
Gecko http://hg.mozilla.org/mozilla-central/rev/250bb14d76d4
Gaia 9935ceb4fe96fff48e78b941cfd2a69d8639a418
BuildID 20131125040208
Version 28.0a1

Comment 1

[Jason Smith [:jsmith]]

Ran - Why are we double refreshing here?

Seems like this is a recent regression too.

Comment 2

[Zac C (:zac)]

Judging from the automation results the *last passing* build was:

Gaia:     13687c598c3b5ef4cff9eef8d0ed3bb57c5f9d65
Gecko:    http://hg.mozilla.org/mozilla-central/rev/dbf94e314cde
BuildID   20131122040202
Version   28.0a1

Comment 3

[Jason Smith [:jsmith]]

Actually, let me leave regression window wanted here.

Can we get the regression window down to a day? That will pin point the regressing commit more directly.

Comment 4

[Jason Smith [:jsmith]]

If it's regressed by a commit on the client-side, then bug 925970 is likely the candidate for causing this.

Comment 5

[J Zimbrick]

Regression Window:

Last Working Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131121040202
Gaia: 71063dd91bc8cbb15ba335236ed67a1c5058bd58
Gecko: cf378dddfac8
Version: 28.0a1
Base Image: V1.2_20131115

First Broken Environmental Variables:
Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131122040202
Gaia: 13687c598c3b5ef4cff9eef8d0ed3bb57c5f9d65
Gecko: dbf94e314cde
Version: 28.0a1
Base Image: V1.2_20131115

Comment 6

[Jason Smith [:jsmith]]

I'm unsure the above regression window is right - Zac's results say that this was working on the 11/22 build. This needs to be double checked.

Comment 7

[J Zimbrick]

Yes, it appears the variables posted above were incorrect. This should be the correct variables, after making an everything.me search on the 20131122123502 build, the search will run again after a few seconds and the results list repopulates.

Regression Window:

Working:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131122040202
Gaia: 13687c598c3b5ef4cff9eef8d0ed3bb57c5f9d65
Gecko: dbf94e314cde
Version: 28.0a1
Base Image: V1.2_20131115

Broken:
Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131122123502
Gaia: 2cc78d696482e0434b584f5645af55e3105e59a2
Gecko: 3c4fc4279e6a
Version: 28.0a1
Base Image: V1.2_20131115

Comment 8

[Jason Smith [:jsmith]]

Okay, then this is definitely caused by the landing in bug 925970.

Switching needinfo on aus to weigh in on why the double refresh is happening.

Nominating because we're wasting network resources here, which is costly to a user if they are on a data connection.

Comment 9

[Jason Smith [:jsmith]]

Talked with aus in IRC - sounds like it seems odd this is happening by bug 925970, as most of the changes there were CSS based.

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

Bug 935845 might be the cause. Checking it out.

Comment 11

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR

The bug originated in Bug 935845 as clicking the "return" button doesn't clear the 'idle' and 'pause' timeouts (which trigger a search for the exact search term).

Comment 12

[Evyatar 'Tron' Amitay (everything.me)]

Comment on attachment 8338337 [details]
Patch - redirect to github PR

perfect

Comment 13

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8338337 [details]
Patch - redirect to github PR

10x Ran

Comment 14

[Ran Ben Aharon [:ranbena] EverythingMe]

Landed on master
https://github.com/mozilla-b2g/gaia/commit/ffb42451ca87be367df9127240a151c2b3acec54

Comment 15

[Zac C (:zac)]

(In reply to Ran Ben Aharon (Everything.me) from comment #14)
> Landed on master
> https://github.com/mozilla-b2g/gaia/commit/
> ffb42451ca87be367df9127240a151c2b3acec54

I'm sorry but it's still replicating on today's builds. It definitely includes your commit, I double checked it.

Which device did you test it on? I'm using a Hamachi.

Comment 16

[Ran Ben Aharon [:ranbena] EverythingMe]

Tested on Unagi. Can you re-test? :/

Comment 17

[Zac C (:zac)]

Sorry, same again today..

Comment 18

[Zac C (:zac)]

Attachment: Video of failure

Comment 19

[Zac C (:zac)]

Attachment: Logcat corresponding with attached video

Comment 20

[Zac C (:zac)]

Attachment: VID_0019.3gp

Comment 21

[Ran Ben Aharon [:ranbena] EverythingMe]

Zac, thanks for hanging in there :)
I've found it was a mistake I made in the original patch.

I'll back out the patch as soon as Gaia reopens and re-PR it with the fix.

Comment 22

[Ran Ben Aharon [:ranbena] EverythingMe]

Backed out the commit
https://github.com/mozilla-b2g/gaia/commit/45cbe2be45c1653765e23c4c1e4aea8ae7e41b8d

Comment 23

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Redirect to Github

Same patch as before but with the small fix

Comment 24

[Ran Ben Aharon [:ranbena] EverythingMe]

Landed on master
https://github.com/mozilla-b2g/gaia/commit/43c37ef8e3f0cca203b1f151cd49e72ccffd8d07

This time for real realz