936026 - Password fields not re-filled and login autocomplete not attached after back/forward navigation

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[u426980]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131025151332

Steps to reproduce:

1. Go to a page with a login form (ie. reddit.com). 
2. Go to any other page afterward.
3. Press "back" button, use mouse-button, or keyboard shortcut to go back.


Actual results:

Username is filled in but not password.


Expected results:

Username and password should be filled in.

Comment 1

[Loic]

I don't tink it's valid for any login form.

I tried on a phpBB forum and login/password are filled after clicking on "back".

Comment 2

[Matthew N. [:MattN]]

I can reproduce this on Nightly and I have a testcase I will upload.

My understanding is that browsers don't save the password state upon navigation as it would make it possible for people to retrieve a password from a login form by going back in history. If the password is saved in the password manager and autofill is enabled, then we could re-fill the password field in this case. 

DOMFormHasPassword doesn't fire again in the normal case (and I don't think that would be expected) but we could listen for the "pageshow" event and call LoginManagerContent.onContentLoaded after modifying it to check event.persisted and work with useDOMFormHasPassword.

I couldn't find another bug on this but I have a hard time believing this is the first report.

Comment 3

[Matthew N. [:MattN]]

Attachment: Testcase

Comment 4

[Matthew N. [:MattN]]

See bug 946549 comment 3 for a method which could be used for this.

Comment 5

[Matthew N. [:MattN]]

While investigating bug 1378754, I realized that the cause of this was the removal of the STATE_RESTORING progress listener handling[1] in bug 839961. The onStateChange handler was simply replaced with a DOMContentLoaded listener but that doesn't handle this case coming from bfcache.

-            // Fastback doesn't fire DOMContentLoaded, so process forms now.
-            if (aStateFlags & Ci.nsIWebProgressListener.STATE_RESTORING) {
-                log("onStateChange: restoring document");
-                return this._pwmgr._fillDocument(domDoc);
-            }

Since _fillDocument also handled markAsLoginManagerField and nsFormFillController clears the hash table of marked login manager fields upon pagehide, this change also broke login autocompletion while navigating in session history.

[1] https://hg.mozilla.org/mozilla-central/rev/58d5552a5ef4#l4.174

Comment 6

[Matthew N. [:MattN]]

We really need a test for both broken things upon session history navigation:
* auto-filling with one matching login
* autocompletion on the username field

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 8

[Matthew N. [:MattN]]

The autocomplete portion was handled by bug 1378754 but we should still add a test for it. Autofill should still be affected.

Comment 9

[Matthew N. [:MattN]]

Taking this since this is related to the progress listeners in bug 1287202.

Comment 10

[Matthew N. [:MattN]]

Attachment: Bug 936026 - Autofill login forms after restoring documents from bfcache. r=jaws

Comment 11

[Matthew N. [:MattN]]

Attachment: Bug 936026 - Test autofilling logins in documents restored from bfcache. r=jaws

Depends on D22212

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4044386c8ae
Autofill login forms after restoring documents from bfcache. r=jaws
https://hg.mozilla.org/integration/autoland/rev/d06cbdecb389
Test autofilling logins in documents restored from bfcache. r=jaws

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e4044386c8ae
https://hg.mozilla.org/mozilla-central/rev/d06cbdecb389

Comment 14

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 936026) for causing Adroid mochitest failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=4dd974f8c7788f401b9dd8102b425ed1321fe0f3&revision=d06cbdecb3890be89b7f514ba0612650dc929065&selectedJob=234962821

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234962821&repo=autoland&lineNumber=2390

Backout: https://hg.mozilla.org/integration/autoland/rev/77453788170e8775e2e0b9a2cb44779d583137ca

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ce441f87fdf
Autofill login forms after restoring documents from bfcache. r=jaws
https://hg.mozilla.org/integration/autoland/rev/48cd73fc0893
Test autofilling logins in documents restored from bfcache. r=jaws

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4ce441f87fdf
https://hg.mozilla.org/mozilla-central/rev/48cd73fc0893