946549 - Remove dead code obsoleted by bug 355063 to fill passwords on load

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Bug 355063 made a number of changes to how password manager worked, but retained the old behavior behind a pref (per tree rules about being able to backout or disable new features).

That code has been fine, and it's about to go to release in Firefox 26 in a few days. So we should remove the pref and now-dead code.

[Untested patch because my build is busted at the moment. :(]

Comment 1

[Justin Dolske [:Dolske]]

Comment on attachment 8342818 [details] [diff] [review]
Patch v.1

pwmgr tests pass locally.

Comment 2

[Justin Dolske [:Dolske]]

(No review rush, I don't want to land this until after next week's uplift anyway.)

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8342818 [details] [diff] [review]
Patch v.1

Review of attachment 8342818 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/LoginManagerContent.jsm
@@ -557,5 @@
> -     *
> -     * Called when a page has loaded. For each form in the document,
> -     * we check to see if it can be filled with a stored login.
> -     */
> -    _fillDocument : function (doc) {

Note that I was actually going to use this method with DOMFormHasPassword to fix 936026. See 936026 comment 2.

Comment 4

[Matthew N. [:MattN]]

(In reply to Matthew N. [:MattN] from comment #3)
> See bug 936026 comment 2.

Comment 5

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/integration/fx-team/rev/626c9723e0ad

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/626c9723e0ad