Closed Bug 936120 Opened 7 years ago Closed 7 years ago

Add Hamachi support to Orangutan

Categories

(Testing Graveyard :: Orangutan, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(2 files)

Currently the Hamachi does not work with Orangutan. We want this so we can do eideticker tests with this device, amongst other things.
The hamachi wants a button down event on every press, and a button up on every release. I also took this opportunity to clean up some other events we were sending.
Attachment #8335355 - Flags: review?(dave.hunt)
(In reply to William Lachance (:wlach) from comment #1)
> Created attachment 8335355 [details] [diff] [review]
> 0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch
> 
> The hamachi wants a button down event on every press, and a button up on
> every release. I also took this opportunity to clean up some other events we
> were sending.

(this was tested on the hamachi, inari, and Galaxy Nexus -- all seem to work fine!)
Now that we perform a button down on every press, and a button up on every release, we no longer need the synthetic event on orangutan startup to wake up the inari.
Attachment #8335356 - Flags: review?(dave.hunt)
Comment on attachment 8335355 [details] [diff] [review]
0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch

Review of attachment 8335355 [details] [diff] [review]:
-----------------------------------------------------------------

I'm unable to get this to work on my Hamachi. Here's what I've tried:

clone orangutan
apply this patch
download android ndk r9b
configure, make, and push orangutan (I had to modify the Makefile as mentioned in bug 942181)

I then ran ./test-orng.py with the homescreen running, but neither swipe_left or swipe_right had any effect. I also tried with --input-device=/dev/input/event4 without success.

Am I missing something here? For what it's worth, with this patch applied Orangutan does still work on my Inari.
Attachment #8335355 - Flags: review?(dave.hunt) → review-
(In reply to Dave Hunt (:davehunt) from comment #4)
> Comment on attachment 8335355 [details] [diff] [review]
> 0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch
> 
> Review of attachment 8335355 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm unable to get this to work on my Hamachi. Here's what I've tried:
> 
> clone orangutan
> apply this patch
> download android ndk r9b
> configure, make, and push orangutan (I had to modify the Makefile as
> mentioned in bug 942181)
> 
> I then ran ./test-orng.py with the homescreen running, but neither
> swipe_left or swipe_right had any effect. I also tried with
> --input-device=/dev/input/event4 without success.
> 
> Am I missing something here? For what it's worth, with this patch applied
> Orangutan does still work on my Inari.

Hmm, seems to work for me? You do need to specify --input-device as follows:

python test-orng.py --input-device /dev/input/event4

Also note that swipe_left and swipe_right do the opposite of what you'd expect, as the name refers to the physical gesture, not the direction of movement (which is the opposite).
I can't imagine why, but I guess it's theoretically possible the SDK version used could make a difference? Just in case, I uploaded a copy of orng I built here:

http://people.mozilla.com/~wlachance/orng
Comment on attachment 8335355 [details] [diff] [review]
0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch

This was my error, I had applied the wrong patch. I guess I shouldn't try reviewing patches with a fever! With the correct patch applied, this works perfectly! :)
Attachment #8335355 - Flags: review- → review+
Comment on attachment 8335356 [details] [diff] [review]
0002-Bug-936120-Remove-code-to-perform-a-button-down-wake.patch

Review of attachment 8335356 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me on inari and hamachi.
Attachment #8335356 - Flags: review?(dave.hunt) → review+
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.