936120 - Add Hamachi support to Orangutan

Status: RESOLVED FIXED

(Testing Graveyard :: Orangutan, defect)

Description

[William Lachance (:wlach)]

Currently the Hamachi does not work with Orangutan. We want this so we can do eideticker tests with this device, amongst other things.

Comment 1

[William Lachance (:wlach)]

Attachment: 0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch

The hamachi wants a button down event on every press, and a button up on every release. I also took this opportunity to clean up some other events we were sending.

Comment 2

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #1)
> Created attachment 8335355 [details] [diff] [review]
> 0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch
> 
> The hamachi wants a button down event on every press, and a button up on
> every release. I also took this opportunity to clean up some other events we
> were sending.

(this was tested on the hamachi, inari, and Galaxy Nexus -- all seem to work fine!)

Comment 3

[William Lachance (:wlach)]

Attachment: 0002-Bug-936120-Remove-code-to-perform-a-button-down-wake.patch

Now that we perform a button down on every press, and a button up on every release, we no longer need the synthetic event on orangutan startup to wake up the inari.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8335355 [details] [diff] [review]
0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch

Review of attachment 8335355 [details] [diff] [review]:
-----------------------------------------------------------------

I'm unable to get this to work on my Hamachi. Here's what I've tried:

clone orangutan
apply this patch
download android ndk r9b
configure, make, and push orangutan (I had to modify the Makefile as mentioned in bug 942181)

I then ran ./test-orng.py with the homescreen running, but neither swipe_left or swipe_right had any effect. I also tried with --input-device=/dev/input/event4 without success.

Am I missing something here? For what it's worth, with this patch applied Orangutan does still work on my Inari.

Comment 5

[William Lachance (:wlach)]

(In reply to Dave Hunt (:davehunt) from comment #4)
> Comment on attachment 8335355 [details] [diff] [review]
> 0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch
> 
> Review of attachment 8335355 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm unable to get this to work on my Hamachi. Here's what I've tried:
> 
> clone orangutan
> apply this patch
> download android ndk r9b
> configure, make, and push orangutan (I had to modify the Makefile as
> mentioned in bug 942181)
> 
> I then ran ./test-orng.py with the homescreen running, but neither
> swipe_left or swipe_right had any effect. I also tried with
> --input-device=/dev/input/event4 without success.
> 
> Am I missing something here? For what it's worth, with this patch applied
> Orangutan does still work on my Inari.

Hmm, seems to work for me? You do need to specify --input-device as follows:

python test-orng.py --input-device /dev/input/event4

Also note that swipe_left and swipe_right do the opposite of what you'd expect, as the name refers to the physical gesture, not the direction of movement (which is the opposite).

Comment 6

[William Lachance (:wlach)]

I can't imagine why, but I guess it's theoretically possible the SDK version used could make a difference? Just in case, I uploaded a copy of orng I built here:

http://people.mozilla.com/~wlachance/orng

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8335355 [details] [diff] [review]
0001-Bug-936120-Make-orangutan-work-on-the-hamachi-r-dave.patch

This was my error, I had applied the wrong patch. I guess I shouldn't try reviewing patches with a fever! With the correct patch applied, this works perfectly! :)

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8335356 [details] [diff] [review]
0002-Bug-936120-Remove-code-to-perform-a-button-down-wake.patch

Review of attachment 8335356 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me on inari and hamachi.

Comment 9

[William Lachance (:wlach)]

Pushed:

https://github.com/mozilla-b2g/orangutan/commit/3d9657f751eb5f79042003466e114a016a97ee6c
https://github.com/mozilla-b2g/orangutan/commit/cb27d3dc0a59941959f993695e324f862a55eac5