936579 - (Hungarian-WordPrediction) [B2G][1.2][l10n][Keyboard] Hungarian: Auto correction is not present

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tony Nguyen]

Attachment: Screenshot

When Hungarian is selected as a Built-in Keyboard, there will not be any auto correction feature. 


Repro Steps:
1) Updated Buri to v 1.2 comRIL BuildID: 20131108004004
2) Navigate to Settings App
3) Navigate into Keyboards and tap Selected Keyboards
4) Tap on Add more keyboards and select Magyar
5) Tap '<' button to go back to Keyboards menu
6) Tap on Built-in Keyboard and verify Auto correction box is checked
7) Return to Homescreen
8) Open Messages App
9) Tap into Message field to bring up keyboard 
10) Long press on globe icon next to the space bar to bring up keyboard Layout selection
11) Select Built-in Keyboard Magyar
12) Begin typing

Actual:
Auto correction is not present for Hungarian language

Expected:
Auto correction is present for Hungarian language

Environmental Variables:
Device: Buri v1.2 comRIL
BuildID: 20131108004004
Gaia: b401bfed469e1d6db24e910f78732bad32843e8a
Gecko: a886c641a306
Version: 26.0
Firmware Version: US_20131104
RIL Information: 01.02.00.019.102

Repro frequency: 100%
See attached: Screenshot

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Ok adding David here to see if he can help out with this

Comment 2

[Tony Nguyen]

This issue is not present on Leo 1.1 device build: 20131030041204. The user experiences Auto correction and Word suggestions when typing in a message using the Hungarian keyboard. 

Environmental Variables:
BuildID: 20131030041204
Gaia: 39b0203fa9809052c8c4d4332fef03bbaf0426fc
Gecko: 41c15ddb7216
Version: 18.0

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Confirmed on master as well.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

For some reason the autocorrect language was not in the keyboard layout in 1.2 and master.

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

Oh and this should be koi+.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 830066 [details] [review]
Patch

r=me.
Thank you, Jan.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Landed https://github.com/mozilla-b2g/gaia/commit/fecd21241feb20df0e9bbed2f279c42112cd283c

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted fecd21241feb20df0e9bbed2f279c42112cd283c to:
v1.2: 8d36764edec2949e5e7acc85f534c739ae3e8bc8

Comment 9

[Lionel Mauritson]

Autocorrect verified present on v1.2

Environmental Variables:
Device: (example: Buri v1.2 Mozilla RIL)
BuildID: 20131202004001
Gaia: 075e60c878b0eca68fba9e00bc85cb6eac03578a
Gecko: 14868788d50e
Version: 26.0
Firmware Version: V1.2_20131115