936973 - list of downloads in Library wastes too much space / entries to wide/large/tall

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect, P3)

Description

[msjs]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20131030130144

Steps to reproduce:

Install FF 24 ESR.
Download a number of files.
Open Downloads (Tools/Downloads).
View downloads.


Actual results:

Too much wasted space between items listed.


Expected results:

Half the space could have been used.

The new Downloads in the Library is a great idea but using so much space is inconsisant with History and Bookmarks. There is no space between these.

The old browser.download.useToolkitUI method used more space than it needed to but would often lock up FF while the download window was open so I would prefer the new way. 
It's been open for 30 mins and no sign of excess cpu use.

Comment 1

[Marco Bonardo [:mak]]

there is a planned redesign of the panel to reduce the padding/margin, so it may be wise to also evaluate doing something in the Library.
That said, we don't plan to make it consistent with how history/bookmarks are shown. I am confirming just to investigate whether we may reduce a little bit the padding there.

Comment 2

[Mike Hoye [:mhoye]]

Following the triage meetings, this remains unassigned. Mak, would you be willing to mentor a community member through this bug?

Comment 3

[Marco Bonardo [:mak]]

I don't think it's easy enough for a community member, unless he is quite skilled with xul, this is not just about changing some css, I think it's a complete redesign following the downloads panel mock-up style ( http://people.mozilla.org/~mmaslaney/fx_download_libraryPanel/index.html see also bug 822763)

Comment 4

[Anup Kumar [:reznord]]

Hi, 

I am interested in working on this bug. So please can you assign this to me?

Regards,
Anup

Comment 5

[Manish Goregaokar [:manishearth]]

Assigned as per request in IRC.

Comment 6

[Rob Campbell [:rc] (:robcee)]

(In reply to Manish Goregaokar [:manishearth] from comment #5)
> Assigned as per request in IRC.

fyi, for new contributors we don't usually assign bugs until they've posted a patch. They should feel free to work on it and ask questions though.

I see Anup's already assigned to three bugs in various parts of our codebase.

Comment 7

[Rob Campbell [:rc] (:robcee)]

... and fixed 4! Carry on. :)

Comment 8

[Anup Kumar [:reznord]]

(In reply to Marco Bonardo [:mak] from comment #3)
> I don't think it's easy enough for a community member, unless he is quite
> skilled with xul, this is not just about changing some css, I think it's a
> complete redesign following the downloads panel mock-up style 

Hi Mak,

I didn't get what are the changes to be done for this bug. 

Thanks in advance,

Regards,
Anup

Comment 9

[Marco Bonardo [:mak]]

the specifics are here 
http://people.mozilla.org/~mmaslaney/fx_download_libraryPanel/index.html
we should likely change the binding of the downloads row to split out the buttons on the right from the area on the left (that will still execute the default command)

the graphic assets are in bug 822763
The only missing thing looks like being the visual feedback on hover/click, I guess it should be consistent with the downloads panel in this mock-up
http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/windows8.html

Comment 10

[Abhishek Bhattacharya [:babhishek21]]

Is this still relevant?

Comment 11

[Marco Bonardo [:mak]]

yes, it's still relevant the design is in comment 9, I hope Paolo can help me mentoring this as a second mentor cause I have quite some requests usually.

Comment 12

[:Paolo Amadini]

I can help with mentoring this, with the assumption that it's not an easy bug to work on and it may take some time, and will probably need to be broken down in smaller tasks.

I'd like to see bug 1117145 done as a first step here, so that we don't diverge the Library and Downloads Panel handling code and styles further.

Comment 13

[Marco Bonardo [:mak]]

So likely bug 1117145 should become a diamond mentored bug

Comment 14

[Abhishek Bhattacharya [:babhishek21]]

(In reply to Marco Bonardo [::mak] from comment #13)
> So likely bug 1117145 should become a diamond mentored bug

It is now. So should one start with bug 1117415 first?

Comment 15

[Marco Bonardo [:mak]]

yes please

Comment 16

[Abhishek Bhattacharya [:babhishek21]]

(In reply to Abhishek Bhattacharya [:babhishek21] from comment #14)
> (In reply to Marco Bonardo [::mak] from comment #13)
> > So likely bug 1117145 should become a diamond mentored bug
> 
> It is now. So should one start with bug 1117415 first?

Oopsie. It should be bug 1117145.

Comment 17

[Marco Bonardo [:mak]]

I don't think we should touch this until we get some new mock-up or indication from UX and at that point we'd have something specific to implement.