Closed
Bug 937167
Opened 10 years ago
Closed 8 years ago
[e10s] Paint Flashing tool needs to be remotable
Categories
(DevTools :: General, defect)
Tracking
(e10s+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: rcampbell, Unassigned)
References
Details
(Whiteboard: [e10s-m7])
This is blocking e10s
Comment 1•10 years ago
|
||
Mass tracking-e10s flag change. Filter bugmail on "2be0fcce-e36a-4e2c-aa80-0e3d33eb5406".
tracking-e10s:
--- → +
Updated•9 years ago
|
Whiteboard: [e10s-m7]
Comment 4•9 years ago
|
||
The new rect highlighter introduced in bug 1076866 could be used. This could also be a good next bug for new contributors. Paul, Patrick, are you able to mentor this ?
Flags: needinfo?(pbrosset)
Flags: needinfo?(paul)
Comment 5•9 years ago
|
||
Paul knows this code better so he might correct me if I'm wrong, but here's what I think: The code that draws the painted rectangles in the page is in gecko, in c++, I don't think we want to replace this with the new rect highlighter. What we need to do to make this remotable though is make sure the paintflashing gcli command works remotely (toolkit/devtools/gcli/commands/paintflashing.js).
Flags: needinfo?(pbrosset)
Comment 6•9 years ago
|
||
No, we don't want to use the highlighter for that. We need an actor (or leverage an existing actor) to expose nsIDOMWindowUtils.paintFlashing.
Flags: needinfo?(paul)
Comment 7•9 years ago
|
||
Paul, the etherpad at https://etherpad.mozilla.org/devtools-e10s-statuses says that this bug is assigned to you, but the bug isn't assigned to you. Are you still planning to work on this in the near future?
Flags: needinfo?(paul)
Comment 8•9 years ago
|
||
(In reply to Eddy Bruel [:ejpbruel] from comment #7) > Paul, the etherpad at https://etherpad.mozilla.org/devtools-e10s-statuses > says that this bug is assigned to you, but the bug isn't assigned to you. > Are you still planning to work on this in the near future? No.
Flags: needinfo?(paul)
Comment 10•9 years ago
|
||
This should be fixed as part of the command line remoting in bug 1128988
Updated•9 years ago
|
Summary: Paint Flashing tool needs to be remotable → [e10s] Paint Flashing tool needs to be remotable
Comment 11•8 years ago
|
||
This now works for me on Nightly and DevEdition as of August 10th. Feel free to reopen if I'm wrong.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•