Closed Bug 1128988 Opened 5 years ago Closed 5 years ago

[e10s] Land runAt support for commands/converters in GCLI

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P1)

defect

Tracking

(e10s+, firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
e10s + ---
firefox40 --- fixed

People

(Reporter: jwalker, Assigned: jwalker)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [polish-backlog][difficulty=hard])

Attachments

(1 file, 3 obsolete files)

No description provided.
Was this filed right Joe? Looks like this was supposed to track, but I'm not sure. Anyway, for dev tools e10s bugs we usually track to the dte-e10s meta and mark tracking-e10s:+. Does that fit this bug?
Flags: needinfo?(jwalker)
(In reply to Jim Mathies [:jimm] from comment #1)
> Was this filed right Joe? Looks like this was supposed to track, but I'm not
> sure. Anyway, for dev tools e10s bugs we usually track to the dte-e10s meta
> and mark tracking-e10s:+. Does that fit this bug?

AIUI, this work will enable GCLI commands to work with e10s.  I'll block the meta bug.
Blocks: dte10s
As jryans said, this is an e10s bug. I'm not sure what the correct meta-fu is for that, but whatever works is good for me.
This bug should fix bug 1034511 and bug 1074233.
Flags: needinfo?(jwalker)
Attached patch 1128988.patch (obsolete) — Splinter Review
This is not complete yet, I'm working through the commands making sure they work properly, but I expect most of my changes from here to be additions, and I'd like to set the ball rolling.

I've broken out and described in detail the changes here https://github.com/joewalker/gecko-dev/pull/7
Assignee: nobody → jwalker
Attachment #8565357 - Flags: feedback?(bgrinstead)
Summary: Land runAt support for commands/converters in GCLI → [e10s] Land runAt support for commands/converters in GCLI
This bug blocks bug 1074233, which is M6, so I propose to track this bug for M6 as well.
Status: NEW → ASSIGNED
Whiteboard: [devedition-40][difficulty=hard]
Priority: -- → P1
Joe, can you fill us in on the status of this work? The e10s team is curious if anyone is working on this currently.
Flags: needinfo?(jwalker)
(In reply to Jim Mathies [:jimm] from comment #7)
> Joe, can you fill us in on the status of this work? The e10s team is curious
> if anyone is working on this currently.

I'm working on it. Progress here: https://github.com/joewalker/gecko-dev/pulls
Hope to be done in a few days
Flags: needinfo?(jwalker)
See Also: → 1154504
Attached patch gcli-leak-fix.patch (obsolete) — Splinter Review
After debugging the leaks, I found this fixed browser_dbg_cmd-dbg.js
https://hg.mozilla.org/mozilla-central/rev/6ecd33215340
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Somehow this has caused the Inspect Element button to disappear in the Browser Toolbox (Bug 1157906).  Looks like it may be a loader issue?

Module `definitions` is not found at resource://gre/modules/commonjs/definitions.js

"@resource:///modules/devtools/commandline/commands-index.js:82:22GcliActor<._getRequisition@resource://gre/modules/devtools/server/actors/gcli.js:245:22GcliActor<.specs<@resource://gre/modules/devtools/server/actors/gcli.js:96:12actorProto/</handler@resource://gre/modules/devtools/server/protocol.js:1006:19DSC_onPacket@resource://gre/modules/devtools/server/main.js:1456:15DebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/devtools/transport/transport.js:471:9makeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.js:82:14makeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.js:82:14"
Depends on: 1157906
FYI, to run the Browser Toolbox in a separate window so you can see logs, you can open up a normal BT on  so that the server starts and then run a separate command:

./mach run --profile /tmp/foobar -chrome chrome://browser/content/devtools/framework/toolbox-process-window.xul --purgecaches --jsconsole
Depends on: 1160345
Depends on: 1160361
Depends on: 1161131
Depends on: 1164537
Depends on: 1164887
Whiteboard: [devedition-40][difficulty=hard] → [polish-backlog][difficulty=hard]
Depends on: 1209149
Depends on: 1169667
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.