Closed Bug 937393 Opened 11 years ago Closed 10 years ago

Define the "browser.newtab.enabled" pref in metro.js to avoid exceptions

Categories

(Firefox for Metro Graveyard :: General, defect, P1)

Product:
Firefox for Metro Graveyard
Component:
General
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 929689

People

(Reporter: TimAbraldes, Unassigned)

Details

I have been seeing this in my error console:
  [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: resource://gre/modules/NewTabUtils.jsm :: <TOP_LEVEL> :: line 223"  data: no]
resource://gre/modules/NewTabUtils.jsm
223

It looks like NewTabUtils.jsm expects the pref "browser.newtab.enabled" to exist, but in metro we don't define this pref.

[1] https://mxr.mozilla.org/mozilla-central/source/toolkit/modules/NewTabUtils.jsm?r=1accaa61b257#218
Blocks: metrobacklog
Whiteboard: p=0
Assignee: nobody → ally
Status: NEW → ASSIGNED
Priority: -- → P1
QA Contact: kamiljoz
Whiteboard: p=0 → p=0 s=it-30c-29a-28b.3 r=ff30
Whiteboard: p=0 s=it-30c-29a-28b.3 r=ff30 → p=1 s=it-30c-29a-28b.3 r=ff30
looks like thee pref is actually "browser.newtabpage.enabled" [1] and we already have that in metro.js line 43 on m-c.

Tim, I see the pref and I don't see the error on today's m-c. Is that the case for you?

https://mxr.mozilla.org/mozilla-central/source/toolkit/modules/NewTabUtils.jsm#39
Flags: needinfo?(tabraldes)
Looks like jimm fixed this in bug 929689
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(tabraldes)
Resolution: --- → DUPLICATE
Assignee: ally → nobody
No longer blocks: metrobacklog
QA Contact: kamiljoz
Whiteboard: p=1 s=it-30c-29a-28b.3 r=ff30
wfm :)
You need to log in before you can comment on or make changes to this bug.