Closed
Bug 937532
Opened 11 years ago
Closed 11 years ago
Migrate calendar tests to use an app object
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Assigned: johan.lorenzo)
References
Details
Attachments
(2 files)
Migrate to an app object following existing app object model.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #830714 -
Flags: review?(trifandreialin)
Attachment #830714 -
Flags: review?(florin.strugariu)
Attachment #830714 -
Flags: review?(andrei.hutusoru)
Updated•11 years ago
|
Attachment #830714 -
Flags: review-
Comment 2•11 years ago
|
||
Comment on attachment 830714 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/13607
there is a small nit
and zac is right we have to migrate both files
Attachment #830714 -
Flags: review?(florin.strugariu) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Updated PR https://github.com/mozilla-b2g/gaia/pull/13607 to correct the nit and migrate the second test.
Updated•11 years ago
|
Attachment #830714 -
Flags: review?(moz.teodosia)
Attachment #830714 -
Flags: review?(florin.strugariu)
Attachment #830714 -
Flags: review-
Comment 4•11 years ago
|
||
Comment on attachment 830714 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/13607
r+
Attachment #830714 -
Flags: review?(trifandreialin) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Fixed last nits. Commits squashed.
Reporter | ||
Comment 6•11 years ago
|
||
Thanks Johan. Will wait for a green Travis and then merge.
Reporter | ||
Comment 7•11 years ago
|
||
Comment on attachment 830714 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/13607
v.nice pull Johan!
r+ from us.
Attachment #830714 -
Flags: review?(moz.teodosia)
Attachment #830714 -
Flags: review?(florin.strugariu)
Attachment #830714 -
Flags: review?(andrei.hutusoru)
Attachment #830714 -
Flags: review+
Reporter | ||
Comment 8•11 years ago
|
||
Merged to master:
https://github.com/mozilla-b2g/gaia/commit/156a7435d1972cadd217684ccf5a5899028d50df
I have marked this b2g26_v1.2 affected because on top of this we will build and re-enable some new test coverage in the future which will be beneficial to both branches.
status-b2g-v1.2:
--- → affected
Comment 9•11 years ago
|
||
Pointer to Github pull-request
Comment 10•11 years ago
|
||
Comment on attachment 8334569 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13842
Uplifting to v1.2
Attachment #8334569 -
Flags: review?(trifandreialin)
Attachment #8334569 -
Flags: review?(moz.teodosia)
Attachment #8334569 -
Flags: review?(bob.silverberg)
Updated•11 years ago
|
Attachment #8334569 -
Flags: review?(moz.teodosia) → review+
Updated•11 years ago
|
Attachment #8334569 -
Flags: review?(trifandreialin)
Attachment #8334569 -
Flags: review?(bob.silverberg)
Attachment #8334569 -
Flags: review+
Comment 11•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•