937653 - Build a new endpoint serving android snippets JSON

Status: VERIFIED FIXED

(Snippets :: Service, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

This endpoint will serve only json/android snippets that match the client-match rules in the request URL. It will serve all geographies and the client will sort out any geotargeted snippets.

Let's use this bug's comments to specify the actual URL this endpoint will live at.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Current snippet url config lives under

browser.aboutHomeSnippets.updateUrl

and has a default value of

https://snippets.mozilla.com/%STARTPAGE_VERSION%/%NAME%/%VERSION%/%APPBUILDID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/


Margaret:

Do you plan to use the same configuration variable (updateUrl) or you'll be adding a new one?

I'm asking so we can decide whether we will have to use the same endpoint for Android and depend on the %NAME% change to serve json and the Android snippets

OR

we are given the chance to create a new similar endpoint like for example:

https://snippets.mozilla.com/json/%STARTPAGE_VERSION%/%NAME%/%VERSION%/%APPBUILDID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/

(Note the "json" part at the start)

Thanks!

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Got the answer on IRC:

<mkelly> giorgos: margaret said they're using a seperate pref
<mkelly> So we can set the URL to whatever

Comment 3

[:Margaret Leibovic]

If you want to test, I put a test build with the patch from bug 937820 here (it will show up as fennec_leibovic in your app launcher):
https://dl.dropboxusercontent.com/u/3358452/fennec-snippets.apk

Here's the pref that patch uses:
pref("browser.snippets.updateUrl", "https://snippets.mozilla.com/json/%SNIPPETS_VERSION%/%NAME%/%VERSION%/%APPBUILDID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/");

I used a %SNIPPETS_VERSION% variable name instead of %STARTPAGE_VERSION%, but the idea should be the same. Right now I just have it set to 1. So the URL this build actually uses is:
https://snippets.mozilla.com/json/1/Fennec/28.0a1/20131118093510/Android_arm-eabi-gcc3/en-US/default/Linux%2018/default/default/

Feel free to go into about:config to change the pref to a development URL.

(Also, FYI, that build just uses a hardcoded "US" country code, and it doesn't ping any metrics server.)

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Commit pushed to master at https://github.com/mozilla/snippets-service

https://github.com/mozilla/snippets-service/commit/92a285cf403fb171aadd638afd2526c132370552
[bug 937650][bug 937653] JSON Snippets models and views.