962349 - Enable snippets

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Snippets are currently disabled by default, but the snippets JSON endpoint just went into production, so we should flip the switch!

Comment 1

[:Margaret Leibovic]

Attachment: patch

Right now there are no snippets in production, so this won't have any user-visible effect. However, I did verify that with this pref flipped, we're getting a valid response from the snippets server, and caching an empty array in snippets.json.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8363892 [details] [diff] [review]
patch

Review of attachment 8363892 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/720e51754413

As I said above, there should be no user-visible effect now, but once there are live snippets targeting Nightly, users should start seeing them.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/720e51754413

Comment 5

[Wesley Johnston (:wesj)]

backed this out to try and diagnose some eideticker regressions:
https://hg.mozilla.org/integration/fx-team/rev/1a81ffef4464

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/1a81ffef4464

Note that this landed prior to the uplift, so it's still on Aurora29.

Comment 7

[:Margaret Leibovic]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #6)
> Merge of backout:
> https://hg.mozilla.org/mozilla-central/rev/1a81ffef4464
> 
> Note that this landed prior to the uplift, so it's still on Aurora29.

Thanks, Ryan. We're using this as a diagnostic tool, and hopefully if we figure out that this caused the regression, we'll try some more things to improve snippets performance, since we really do want to enable them for 29.

Comment 8

[:Margaret Leibovic]

Re-landing with bug 964511:
https://hg.mozilla.org/integration/fx-team/rev/494ca694e768

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/494ca694e768