Closed Bug 937730 Opened 9 years ago Closed 9 years ago

Contacts should not have avatar images for Eideticker

Categories

(Testing Graveyard :: Eideticker, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: davehunt)

References

Details

(Keywords: perf, Whiteboard: [c=automation p= s=2014.01.17 u=])

Attachments

(1 file)

According to :bkelly, contact avatars are designed to be loaded asynchrously, and we should not count on them appearing in a timely fashion when the contacts app starts up.

To stabilize the load numbers for eideticker, let's just remove any images for contacts avatars for now.
Status: NEW → ASSIGNED
Keywords: perf
Whiteboard: [c=automation p= s= u=]
The reference workloads [1] we use have contact images, so we'll either need and alternative workload or see if we can simply omit the pictures. Jon: Are you aware of any issues that might come from using the contacts database without the pictures?

[1] https://github.com/mozilla-b2g/gaia/tree/master/test_media/reference-workload
Flags: needinfo?(jhylands)
If you simply delete the numbered files in the subdirectory with the same name as the database, the pictures will not show up. I assume they will still have an impact, because it will try and load each one and fail, but I suspect it will be a much lower impact than loading the actual images.
Flags: needinfo?(jhylands)
So I believe the solution we decided was to modify eideticker to have load and/or modify its workload at the beginning of each test. Dave is working on this at the moment.
Depends on: 942826
Depends on: 942829
Once the blocking bugs are fixed, we'll need to patch eideticker to use the latest version of b2gpopulate and pass the argument so that the contact pictures are not populated.
Comment on attachment 8356581 [details] [diff] [review]
Do not include pictures when populating contacts. v1.0

Thanks!
Attachment #8356581 - Flags: review?(wlachance) → review+
https://github.com/mozilla/eideticker/commit/41761026c04f93d6a4ad5a867bbb455a63427576
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [c=automation p= s= u=] → [c=automation p= s=2014.01.17 u=]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.