937730 - Contacts should not have avatar images for Eideticker

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

According to :bkelly, contact avatars are designed to be loaded asynchrously, and we should not count on them appearing in a timely fashion when the contacts app starts up.

To stabilize the load numbers for eideticker, let's just remove any images for contacts avatars for now.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

The reference workloads [1] we use have contact images, so we'll either need and alternative workload or see if we can simply omit the pictures. Jon: Are you aware of any issues that might come from using the contacts database without the pictures?

[1] https://github.com/mozilla-b2g/gaia/tree/master/test_media/reference-workload

Comment 2

[Jon Hylands [:jhylands]]

If you simply delete the numbered files in the subdirectory with the same name as the database, the pictures will not show up. I assume they will still have an impact, because it will try and load each one and fail, but I suspect it will be a much lower impact than loading the actual images.

Comment 3

[William Lachance (:wlach)]

So I believe the solution we decided was to modify eideticker to have load and/or modify its workload at the beginning of each test. Dave is working on this at the moment.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

Once the blocking bugs are fixed, we'll need to patch eideticker to use the latest version of b2gpopulate and pass the argument so that the contact pictures are not populated.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

Attachment: Do not include pictures when populating contacts. v1.0

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8356581 [details] [diff] [review]
Do not include pictures when populating contacts. v1.0

Thanks!

Comment 7

[William Lachance (:wlach)]

https://github.com/mozilla/eideticker/commit/41761026c04f93d6a4ad5a867bbb455a63427576