942829 - Add option to skip contact pictures in b2gpopulate

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

For bug 937730 we need to be able to populate contacts without their pictures. We should add an optional argument to populate_contacts [1] such as include_pictures which defaults to True. If it's False we should avoid pushing the pictures to the device [2].

At this time we don't need a command line option for this.

[1] https://github.com/mozilla/b2gpopulate/blob/94355d1cc063f6104d44b4eeec9dcca0f67b0bee/b2gpopulate/b2gpopulate.py#L139
[2] https://github.com/mozilla/b2gpopulate/blob/94355d1cc063f6104d44b4eeec9dcca0f67b0bee/b2gpopulate/b2gpopulate.py#L164

Comment 1

[Sebastiaan de Haan [:kyr0]]

Attachment: Bug942829: option: Skip contact picture population

We don't really need the '== True' part but I think it adds to the readability.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8338342 [details] [review]
Bug942829: option: Skip contact picture population

Good start, just a couple of tweaks and I think this will be good to land.

Comment 3

[Sebastiaan de Haan [:kyr0]]

Attachment: Bug942829: option: Skip contact picture population

Comments addressed!

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8338417 [details] [review]
Bug942829: option: Skip contact picture population

Just a couple of comments added to the pull request. With these changes we should be good to merge.

Comment 5

[Sebastiaan de Haan [:kyr0]]

Attachment: Bug 942829 - option: Skip contact picture population

Comments addressed.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8340756 [details] [review]
Bug 942829 - option: Skip contact picture population

Landed in:
https://github.com/mozilla/b2gpopulate/commit/3ed89a1cce0cc41cb72d260133aef4a42a4ab64d